fix(sheets): resolve spreadsheet import potential freeze#319
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| current = current[key]; | ||
| } | ||
| current[segments[segments.length - 1]] = value; |
Contributor
|
🎉 This PR is included in version 1.36.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing Google Sheet log datasets that contain numeric string keys locks up the browser.
Root Cause:
Lodash's
_.setinterprets integer-like string keys in the sheet headers (e.g.,"819054441") as numeric array indices. This creates massive sparse arrays of 800M+ elements. Re-serializing and running recursive normalization mappings over these giant sparse arrays freezes the CPU for ~15.8 seconds per row.Solution
Standard nested arrays in this app are written to single cells as JSON arrays and never flattened, so any numeric keys in sheet headers represent object map keys (like trip IDs) rather than array indexes.
_.setwith a customsetDeepfunction instantiation.lodashimport and dependency