fix: add explicit platform versions to Package.swift#243
Merged
Conversation
Member
Author
|
Tests look like unrelated flakes. |
paulb777
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nanopb fix for firebase/firebase-ios-sdk#16244
The Package.swift did not provide an explicit
platforms: [SupportedPlatform]?. On Xcode 27 beta, this caused watchOS builds to fail. Only watchOS seems to be affected by not being specified in the platforms array.:/Users/nickcooke/Library/Developer/Xcode/DerivedData/app-check-bazhoueefjmiowavinzydkvkoqvm/SourcePackages/checkouts/promises/Package.swift: error: The watchOS Simulator deployment target 'WATCHOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 27.0.x. (in target 'Promises' from project 'Promises' at path '/Users/nickcooke/Library/Developer/Xcode/DerivedData/app-check-bazhoueefjmiowavinzydkvkoqvm/SourcePackages/checkouts/promises/Package.swift')Perhaps we should be setting
watchOS(.v9)as we are explicitly specifying a version out of the logged range, but this would violate Firebase's currently watchOS min. supported version.Observations:
Mirroring the platform support versions from the promises podspec:
From
promises/PromisesSwift.podspec
Lines 19 to 23 in d6d659a
Versioning
We should tag this version as a patch release: 2.4**.1**, so existing Firebase versions pick this up.
https://github.com/firebase/firebase-ios-sdk/blob/7f9f7d761627c827a0c6d7a410c9a111bf220f18/Package.swift#L136-L139