feat: Add Issue Dependencies API support by tommaso-moro · Pull Request #4130 · google/go-github

tommaso-moro · 2026-04-02T14:09:38Z

closes: #4129

Add Issue Dependencies API support

Add support for the Issue Dependencies REST API.

Changes

New file github/issues_dependencies.go adds four methods to IssuesService:

Method	Endpoint	Description
`ListBlockedBy`	`GET /repos/{owner}/{repo}/issues/{issue_number}/dependencies/blocked_by`	List dependencies blocking an issue
`AddBlockedBy`	`POST /repos/{owner}/{repo}/issues/{issue_number}/dependencies/blocked_by`	Add a blocking dependency
`RemoveBlockedBy`	`DELETE /repos/{owner}/{repo}/issues/{issue_number}/dependencies/blocked_by/{issue_id}`	Remove a blocking dependency
`ListBlocking`	`GET /repos/{owner}/{repo}/issues/{issue_number}/dependencies/blocking`	List issues this issue is blocking

Also adds IssueDependencyRequest type used by AddBlockedBy.

Testing

Full test coverage in github/issues_dependencies_test.go (12 tests) using standard helpers: testBadOptions, testNewRequestAndDoFailure, testURLParseError, testJSONMarshal.

Auto-generated files updated via go generate: accessors, accessor tests, iterators, and iterator tests.

All scripts pass: script/fmt.sh, script/test.sh, script/lint.sh.

Add four new methods to IssuesService for the Issue Dependencies REST API (apiVersion 2026-03-10): - ListBlockedBy: list dependencies blocking an issue - AddBlockedBy: add a blocking dependency to an issue - RemoveBlockedBy: remove a blocking dependency - ListBlocking: list issues that an issue is blocking Includes IssueDependencyRequest type, full test coverage with testBadOptions, testNewRequestAndDoFailure, testURLParseError, and testJSONMarshal helpers.

Run go generate to add: - GetIssueID accessor for IssueDependencyRequest - ListBlockedBy and ListBlocking iterators with tests

google-cla · 2026-04-02T14:09:50Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

codecov · 2026-04-02T14:18:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.76%. Comparing base (5124fac) to head (f4e9158).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4130      +/-   ##
==========================================
+ Coverage   93.74%   93.76%   +0.02%     
==========================================
  Files         211      212       +1     
  Lines       19685    19765      +80     
==========================================
+ Hits        18453    18533      +80     
  Misses       1034     1034              
  Partials      198      198

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gmlewis

Thank you, @tommaso-moro!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29 - @Not-Dhananjay-Mishra - @munlicode

github/issues_dependencies.go

tommaso-moro · 2026-04-08T09:12:21Z

@Not-Dhananjay-Mishra thank you for the review! I have addressed the points you raised and updated this branch.

github/issues.go

github/issues_dependencies.go

github/issues_dependencies_test.go

Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>

…dependencies.go Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>

Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>

Per review feedback: both issue_id and issue_number are integer in the OpenAPI spec, so issueNumber should be int64 for consistency.

alexandear · 2026-04-09T13:13:58Z

github/issues.go

+	BlockedBy      *int `json:"blocked_by,omitempty"`
+	Blocking       *int `json:"blocking,omitempty"`
+	TotalBlockedBy *int `json:"total_blocked_by,omitempty"`
+	TotalBlocking  *int `json:"total_blocking,omitempty"`


All these fields are required according to the schema:

Suggested change

BlockedBy *int `json:"blocked_by,omitempty"`

Blocking *int `json:"blocking,omitempty"`

TotalBlockedBy *int `json:"total_blocked_by,omitempty"`

TotalBlocking *int `json:"total_blocking,omitempty"`

BlockedBy int `json:"blocked_by"`

Blocking int `json:"blocking"`

TotalBlockedBy int `json:"total_blocked_by"`

TotalBlocking int `json:"total_blocking"`

alexandear · 2026-04-09T13:14:36Z

github/issues.go

+	Total            *int `json:"total,omitempty"`
+	Completed        *int `json:"completed,omitempty"`
+	PercentCompleted *int `json:"percent_completed,omitempty"`


Suggested change

Total *int `json:"total,omitempty"`

Completed *int `json:"completed,omitempty"`

PercentCompleted *int `json:"percent_completed,omitempty"`

Total int `json:"total"`

Completed int `json:"completed"`

PercentCompleted int `json:"percent_completed"`

alexandear · 2026-04-09T13:15:56Z

github/issues.go

+	IssueFieldID       *int64                  `json:"issue_field_id,omitempty"`
+	NodeID             *string                 `json:"node_id,omitempty"`
+	DataType           *string                 `json:"data_type,omitempty"`


Suggested change

IssueFieldID *int64 `json:"issue_field_id,omitempty"`

NodeID *string `json:"node_id,omitempty"`

DataType *string `json:"data_type,omitempty"`

IssueFieldID int64 `json:"issue_field_id"`

NodeID string `json:"node_id"`

DataType string `json:"data_type"`

alexandear · 2026-04-09T13:16:56Z

github/issues.go

+	ID    *int64  `json:"id,omitempty"`
+	Name  *string `json:"name,omitempty"`
+	Color *string `json:"color,omitempty"`


Suggested change

ID *int64 `json:"id,omitempty"`

Name *string `json:"name,omitempty"`

Color *string `json:"color,omitempty"`

ID int64 `json:"id"`

Name string `json:"name"`

Color string `json:"color"`

alexandear · 2026-04-09T13:18:14Z

github/issues.go

+	IssueFieldID       *int64                  `json:"issue_field_id,omitempty"`
+	NodeID             *string                 `json:"node_id,omitempty"`
+	DataType           *string                 `json:"data_type,omitempty"`
+	Value              any                     `json:"value,omitempty"`


Suggested change

Value any `json:"value,omitempty"`

Value any `json:"value"`

I propose adding the comment that the value can be string, number, or integer.

Not-Dhananjay-Mishra · 2026-04-09T13:33:13Z

github/issues_dependencies.go

+// GitHub API docs: https://docs.github.com/rest/issues/issue-dependencies#remove-dependency-an-issue-is-blocked-by
+//
+//meta:operation DELETE /repos/{owner}/{repo}/issues/{issue_number}/dependencies/blocked_by/{issue_id}
+func (s *IssuesService) RemoveBlockedBy(ctx context.Context, owner, repo string, issueNumber int64, issueID int64) (*Issue, *Response, error) {


Suggested change

func (s *IssuesService) RemoveBlockedBy(ctx context.Context, owner, repo string, issueNumber int64, issueID int64) (*Issue, *Response, error) {

func (s *IssuesService) RemoveBlockedBy(ctx context.Context, owner, repo string, issueNumber, issueID int64) (*Issue, *Response, error) {

tommaso-moro added 2 commits April 2, 2026 11:27

chore: Regenerate accessors and iterators

9aba995

Run go generate to add: - GetIssueID accessor for IssueDependencyRequest - ListBlockedBy and ListBlocking iterators with tests

tommaso-moro mentioned this pull request Apr 2, 2026

Add support for Issue Dependencies REST API #4129

Open

tommaso-moro marked this pull request as ready for review April 2, 2026 14:46

chore: trigger CI

f57a237

gmlewis approved these changes Apr 2, 2026

View reviewed changes

gmlewis added the NeedsReview PR is awaiting a review before merging. label Apr 2, 2026

Not-Dhananjay-Mishra reviewed Apr 3, 2026

View reviewed changes

github/issues_dependencies.go Outdated Show resolved Hide resolved

github/issues_dependencies.go Outdated Show resolved Hide resolved

github/issues_dependencies.go Outdated Show resolved Hide resolved

tommaso-moro and others added 4 commits April 3, 2026 11:49

remove omitempty for required param

76cfab3

pass by value instead of reference as param is required

4550de5

add missing fields to Issue struct

13f260e

Merge branch 'master' into tommy/issue-dependencies-support

14b279b

tommaso-moro requested review from Not-Dhananjay-Mishra and gmlewis April 8, 2026 09:11

munlicode approved these changes Apr 8, 2026

View reviewed changes

alexandear reviewed Apr 8, 2026

View reviewed changes

github/issues.go Outdated Show resolved Hide resolved

alexandear suggested changes Apr 8, 2026

View reviewed changes

tommaso-moro and others added 10 commits April 9, 2026 10:11

use any instead of interface{}

6fd4bfd

Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>

Use int64 instead of *int64 for IssueID

171deba

Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>

Update number param to issueNumber for consistency, in github/issues_…

c5e05bf

…dependencies.go Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>

Update number param to issueNumber in github/issues_dependencies.go

1d84d92

Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>

update number param to issueNumber

a3c6983

fix tests now that IssueID is of type int64

45fb09c

update number param to issueNumber

1e86822

Use int64 for issueNumber parameter

0000b64

Per review feedback: both issue_id and issue_number are integer in the OpenAPI spec, so issueNumber should be int64 for consistency.

clean up test

d261d4f

Merge branch 'master' into tommy/issue-dependencies-support

f4e9158

tommaso-moro requested a review from alexandear April 9, 2026 10:22

alexandear approved these changes Apr 9, 2026

View reviewed changes

Not-Dhananjay-Mishra reviewed Apr 9, 2026

View reviewed changes

	func (s IssuesService) RemoveBlockedBy(ctx context.Context, owner, repo string, issueNumber int64, issueID int64) (Issue, *Response, error) {
	func (s IssuesService) RemoveBlockedBy(ctx context.Context, owner, repo string, issueNumber, issueID int64) (Issue, *Response, error) {

Conversation

tommaso-moro commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Add Issue Dependencies API support

Changes

Testing

Uh oh!

google-cla bot commented Apr 2, 2026

Uh oh!

codecov bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tommaso-moro commented Apr 8, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexandear Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

alexandear Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

alexandear Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

alexandear Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

alexandear Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

alexandear Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Not-Dhananjay-Mishra Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tommaso-moro commented Apr 2, 2026 •

edited

Loading

codecov bot commented Apr 2, 2026 •

edited

Loading