fix: allow builder assistant special app name#5918
Conversation
|
Response from ADK Triaging Agent Hello @he-yufeng, thank you for submitting this pull request! This PR is a bug fix and addresses issue #5877. While you have provided a detailed "To verify" section with the commands, could you please provide:
Providing this verification evidence helps our maintainers review and merge your PR more efficiently. For more details, you can refer to the Contribution Guidelines. Thank you! |
61baef5 to
50f2c0d
Compare
|
Rebased onto current upstream/main and refreshed the PR verification evidence. The targeted pytest commands now report 2 passed and 1 passed respectively; pyink and diff-check also pass. |
485c472 to
6f7d5ca
Compare
|
Rebased this branch on current Validated: $env:PYTHONPATH='C:\dev\GITHUB-clean\adk-python\src'
$env:TMP='C:\dev\GITHUB-clean\adk-python\.tmp'
$env:TEMP='C:\dev\GITHUB-clean\adk-python\.tmp'
.\.venv\Scripts\python.exe -m pytest tests\unittests\cli\test_fast_api.py::test_get_runner_async_accepts_internal_special_agent_name -q --basetemp .tmp\pytest-5918-single --tb=short -vv
.\.venv\Scripts\python.exe -m py_compile src\google\adk\cli\api_server.py tests\unittests\cli\test_fast_api.py
git diff --check upstream/main...HEADResult: the targeted regression passes. I also tried the full |
Summary
adk webrunner construction for internal special agents such as__adk_agent_builder_assistantFixes #5877.
To verify
C:\dev\GITHUB-clean\adk-python\.venv\Scripts\python.exe -m pytest tests\unittests\cli\test_fast_api.py -q -k "special_agent_name or bigquery"— 2 passed, 73 deselected, 8 warningsC:\dev\GITHUB-clean\adk-python\.venv\Scripts\python.exe -m pytest tests\unittests\apps\test_apps.py -q -k "app_name_must_be_valid or path_like"— 1 passed, 15 deselected, 4 warningsC:\dev\GITHUB-clean\adk-python\.venv\Scripts\python.exe -m pyink --check src\google\adk\cli\api_server.py tests\unittests\cli\test_fast_api.py— passed, 2 files left unchangedgit diff --check -- src\google\adk\cli\api_server.py tests\unittests\cli\test_fast_api.py— passed