Skip to content

fix(agents): prevent path traversal in AgentTool config_path resolution #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adilburaksen wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −4
Open

fix(agents): prevent path traversal in AgentTool config_path resolution #1218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions core/src/main/java/com/google/adk/agents/ConfigAgentUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,12 +247,18 @@ private static BaseAgent resolveSubAgentFromConfigPath(
BaseAgentConfig.AgentRefConfig subAgentConfig, Path configDir) throws ConfigurationException {

String configPath = subAgentConfig.configPath().trim();
Path subAgentConfigPath;

if (Path.of(configPath).isAbsolute()) {
subAgentConfigPath = Path.of(configPath);
} else {
subAgentConfigPath = configDir.resolve(configPath);
throw new ConfigurationException(
"Absolute paths are not allowed in AgentTool config_path: " + configPath);
}

Path subAgentConfigPath = configDir.resolve(configPath).normalize().toAbsolutePath();
Path canonicalConfigDir = configDir.normalize().toAbsolutePath();

if (!subAgentConfigPath.startsWith(canonicalConfigDir)) {
throw new ConfigurationException(
"Path traversal detected: config_path resolves outside agent directory: " + configPath);
}

if (!Files.exists(subAgentConfigPath)) {
Expand Down