Fix DPT decoder bugs for Scenic parity#31
Open
bingyic wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes multiple bugs in
pytorch/decoders.pyto achieve numerical parity (max diff < 1e-4) with the Scenic/Flax reference implementation.Changes
DPTHead: Addoutput_activationparameter (defaultFalse).When
True, appliesF.relu()after project conv, matching Scenic.DepthDecoder: Replace with classification-based depth prediction:nn.Linear(channels, num_depth_bins)headbin_centersbuffer viatorch.linspace(min_depth, max_depth, num_depth_bins)relu(logits) + min_depth→ normalize →einsum(probs, bin_centers)ReassembleBlocks: UseF.gelu(x, approximate='tanh')to match JAX default.ConvTranspose kernel: Apply 180° spatial flip during Flax→PyTorch conversion.
load_decoder_weights(): Unified weight loading from Scenic.zipcheckpointswith auto-detection and key remapping for all decoder types:
pixel_segmentation,pixel_depth_classif,pixel_normals→headVerification
All three decoder types verified for numerical parity against Scenic reference: