🛡️ Sentinel: [CRITICAL] Fix SSRF in web_fetch#559
Conversation
🚨 Severity: CRITICAL 💡 Vulnerability: The `handle_web_fetch` in `system_tools_plugin.rs` allowed arbitrary Server-Side Request Forgery (SSRF) because it directly executed HTTP GET requests using `reqwest::blocking::get` without validating the host's IP address. 🎯 Impact: Attackers could access internal services (e.g., localhost, 127.0.0.1, internal subnets) or cloud metadata endpoints (e.g., 169.254.169.254) bypassing external firewalls. 🔧 Fix: Extracted manual IP filtering rules (`is_allowed_ip`) to block loopback, private, unspecified, multicast, and link-local addresses. Rewrote the handler to use `fetch_url_safe` which manually resolves DNS, validates all returned IPs, pins the valid IP using `.resolve()` to prevent TOCTOU DNS rebinding, and manually validates location headers across a maximum of 5 redirects. ✅ Verification: Ran `cargo test -p mill-plugin-system`, `cargo clippy`, and `cargo fmt`. Co-authored-by: mudcube <101564+mudcube@users.noreply.github.com>
Deploying typemill with
|
| Latest commit: |
7e72dcd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b0177a6a.typemill.pages.dev |
| Branch Preview URL: | https://sentinel-ssrf-web-fetch-1060.typemill.pages.dev |
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e72dcd3b0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if valid_ip.is_none() { | ||
| valid_ip = Some(addr); | ||
| } |
There was a problem hiding this comment.
Selecting only the first resolved address (valid_ip) and pinning the client to it can make web_fetch fail for otherwise valid hosts that publish both AAAA and A records. In IPv4-only or partially IPv6-broken environments, if the first address is unreachable (often IPv6), the request fails even though another validated address would succeed. This is a regression from normal resolver behavior (which can try multiple addresses); use all validated addresses (e.g., resolve_to_addrs) or retry across them before failing.
Useful? React with 👍 / 👎.
1 participant
Fixes SSRF vulnerability in web_fetch tool by validating and pinning IP addresses.
PR created automatically by Jules for task 10607010861849805705 started by @mudcube