Skip to content

fix(tracing_utils): handle baggage values containing '=' in from_incoming_header #6450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devteamaegis wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −1
Open

fix(tracing_utils): handle baggage values containing '=' in from_incoming_header #6450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sentry_sdk/tracing_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,7 +719,7 @@ def from_incoming_header(

with capture_internal_exceptions():
item = item.strip()
key, val = item.split("=")
key, val = item.split("=", 1)
if Baggage.SENTRY_PREFIX_REGEX.match(key):
baggage_key = unquote(key.split("-")[1])
sentry_items[baggage_key] = unquote(val)
Expand Down
7 changes: 7 additions & 0 deletions tests/test_tracing_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,3 +279,10 @@ def test_should_continue_trace(

baggage = Baggage.from_incoming_header(baggage_header) if baggage_header else None
assert _should_continue_trace(baggage) == should_continue_trace


def test_baggage_from_incoming_header_value_with_equals_sign():
# Baggage values that legitimately contain '=' (e.g. base64) must not be dropped
header = "sentry-release=v1.0==1,sentry-trace_id=abc123"
baggage = Baggage.from_incoming_header(header)
assert baggage.sentry_items == {"release": "v1.0==1", "trace_id": "abc123"}