Skip to content

ref(server): Remove unnecessary old code for splitting envelopes#6023

Open
Dav1dde wants to merge 10 commits into
masterfrom
dav1d/processing-cleanup
Open

ref(server): Remove unnecessary old code for splitting envelopes#6023
Dav1dde wants to merge 10 commits into
masterfrom
dav1d/processing-cleanup

Conversation

@Dav1dde
Copy link
Copy Markdown
Member

@Dav1dde Dav1dde commented May 27, 2026

  • Removes split_envelope logic
  • Everything which is associated with split_envelope and ProcessingGroup
  • Moves processing into separate RelayProcessor with effectively the same processing logic as before, just easier to understand (hopefully)
  • Makes dropping invalid data explicit (FormData)
  • Raw security reports created multiple errors (and envelopes) from multiple items, these should've been individual envelopes from the beginning (they are now)
  • COGS are tracked slightly differently, I don't expect a noticeable change, will monitor.
  • Does not do any additional cleanup which is now possible, e.g. fn process_envelope can be merged into fn process

@Dav1dde Dav1dde marked this pull request as ready for review May 27, 2026 23:55
@Dav1dde Dav1dde requested a review from a team as a code owner May 27, 2026 23:55
Comment thread relay-server/src/endpoints/security_report.rs
Comment thread relay-server/src/services/processor.rs
Comment thread relay-server/src/services/processor.rs
Comment thread relay-server/src/services/processor.rs Outdated
cursor[bot]

This comment was marked as outdated.

@Dav1dde Dav1dde force-pushed the dav1d/processing-cleanup branch from 853778d to 5eb1f07 Compare May 28, 2026 07:34
Comment thread relay-server/src/services/processor.rs
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5eb1f07. Configure here.

Comment thread relay-server/src/processing/relay.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant