Skip to content

[codex] print validator count to stdout#331

Merged
MuncleUscles merged 1 commit into
v0.39from
fix/studio-validator-count-stdout
May 25, 2026
Merged

[codex] print validator count to stdout#331
MuncleUscles merged 1 commit into
v0.39from
fix/studio-validator-count-stdout

Conversation

@MuncleUscles
Copy link
Copy Markdown
Member

@MuncleUscles MuncleUscles commented May 25, 2026

Summary

  • print localnet validators count results to stdout
  • keep the existing spinner success message

Why

The Studio tooling E2E expects a parseable validator count. The CLI previously only surfaced the count through spinner output, which can be blank or suppressed in CI.

Validation

  • npm test -- tests/actions/validators.test.ts
  • focused Studio CLI validator count E2E locally

Summary by CodeRabbit

  • Chores
    • Enhanced console output for validator count reporting in localnet operations.
    • Code formatting improvements.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9fcc3dbd-1218-4dad-af5b-787339b09fab

📥 Commits

Reviewing files that changed from the base of the PR and between e129bab and 13a735b.

📒 Files selected for processing (1)
  • src/commands/localnet/validators.ts

📝 Walkthrough

Walkthrough

The PR adds console output to the countValidators() function in the validators command, logging the computed total validator count to stdout alongside the existing spinner success message. A trailing blank line at the end of the file is also removed.

Changes

Validator Count Logging

Layer / File(s) Summary
Validator count console output
src/commands/localnet/validators.ts
countValidators() logs the validator total via console.log() before the spinner success message displays. Trailing whitespace is removed from the file end.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A logger's gift, so small and bright,
Counts validators, outputs light,
Console whispers "All is well,"
No trailing blanks—the tale we tell. 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: printing validator count output to stdout, which aligns with the PR's primary objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/studio-validator-count-stdout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MuncleUscles MuncleUscles merged commit 37519e1 into v0.39 May 25, 2026
5 checks passed
@MuncleUscles MuncleUscles deleted the fix/studio-validator-count-stdout branch May 25, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant