Implement chain simulation for evm balance changes#600
Open
0xh3rman wants to merge 3 commits into
Open
Conversation
gemcoder21
reviewed
Jul 2, 2026
gemcoder21
reviewed
Jul 2, 2026
0xh3rman
force-pushed
the
evm-balance-simulation
branch
from
63cbe22 to
0ffc733
Compare
0xh3rman
force-pushed
the
evm-balance-simulation
branch
from
a3789de to
ed35f59
Compare
gemcoder21
approved these changes
Jul 3, 2026
gemcoder21
approved these changes
Jul 3, 2026
| let signer = transaction.from.as_deref().unwrap_or_default(); | ||
|
|
||
| let trace = self.trace_call(&transaction).await?; | ||
| let mut result = map_simulation_result(self.get_chain(), signer, &trace); |
| impl<C: Client + Clone> ChainSimulation for EthereumClient<C> { | ||
| async fn simulate_transaction(&self, input: SimulationInput) -> Result<SimulationResult, Box<dyn Error + Send + Sync>> { | ||
| let transaction: TransactionObject = serde_json::from_str(&input.encoded_transaction)?; | ||
| let signer = transaction.from.as_deref().unwrap_or_default(); |
Contributor
There was a problem hiding this comment.
we should not do .unwrap_or_default();
| } | ||
| } | ||
|
|
||
| pub fn map_balance_change_asset(mut change: SimulationBalanceChange, asset: Asset) -> SimulationBalanceChange { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #589