Feat PadLines: added "Mode" argument#2359
Open
oliver-mitchell wants to merge 3 commits intogchq:masterfrom
Open
Feat PadLines: added "Mode" argument#2359oliver-mitchell wants to merge 3 commits intogchq:masterfrom
oliver-mitchell wants to merge 3 commits intogchq:masterfrom
Conversation
- Added "Mode" argument to the Pad Lines operation. - Added "Fixed Count" mode. Mimics original behaviour, fixed number of characters added to the string. - Added "Target Length" mode. Adds padding characters in order to reach a certain length. - Modified Pad lines implementation to use join rather than slice for final result
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit overview:
Description
Adds a new "Mode" argument to the "Pad Lines" operation. Mode allows the user to configure how many padding characters are added.
The default mode "Fixed Count" mimics the existing behaviour; a fixed number of padding characters is added to the start or end of the string.
The alternative mode "Target Length" differs from "Fixed Count" in that the number of padding characters added is variable; the count argument is instead interpreted as the target length of the overall line.
Existing Issue
N/A
Screenshots
AI disclosure
No AI was used for this change.
Test Coverage
Tests have been added for the Pad line operation.