Add prettier formatter#1736
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ], | ||
| "no-whitespace-before-property": "error", | ||
| "operator-linebreak": ["error", "after"], | ||
| "operator-linebreak": ["error", "before"], |
There was a problem hiding this comment.
Changed operator-linebreak to before to go along with prettier formatting
| - name: Format & Lint | ||
| run: (npm run style || npm run lint) && git diff --exit-code |
There was a problem hiding this comment.
Modified pull_request workflow to include prettier formatting. These checks cannot be made individually in separate steps because it changes the files. Hence doing it together and checking for any file changes
| options: { | ||
| fix: true | ||
| } |
There was a problem hiding this comment.
Added option to fix any linting errors
|
I'm relatively concerned by the number of files changed by this PR. If I merge it, this will cause merge conflicts with the vast number of other PRs that are available right now. I wonder if, perhaps, it's best to wait for me to try to process all of those and then do a single large 'style' pull request. As a side note, you probably want to not style |
|
Hey! This pull request has gotten rather old and that's our fault. This project stopped being actively maintained for a while and it looks like your pull request has started to gather dust. Would you be able to update your branch to the latest version of CyberChef and we'll give it a review? |
|
Hey @a3957273 Definitely. Let me fix this over the weekend and get back to you |
|
If we're thinking about picking this one up to land, can we hold off until #2187 lands? That would definitely kill any chance of that PR ever landing. |
|
Yes, thanks for pointing that out @mattnotmitt , I'll hold off |
5 participants
Fixes #1726 Added prettier as per the GitHub Issue conversation