Skip to content

Disabled RenderingIfaceTest test for win32#1284

Merged
miguelgonrod merged 2 commits intogazebosim:ign-rendering6from
miguelgonrod:ign-rendering6
May 1, 2026
Merged

Disabled RenderingIfaceTest test for win32#1284
miguelgonrod merged 2 commits intogazebosim:ign-rendering6from
miguelgonrod:ign-rendering6

Conversation

@miguelgonrod
Copy link
Copy Markdown

🦟 Bug fix

Fixes #1282

Summary

As told in the Gazebo PMC meeting, as this is fortress and windows regressions, the best approach is to disable the test

+ #include <gz/utils/ExtraTestMacros.hh>
...
- TEST(RenderingIfaceTest, GetEngine)
+ TEST(RenderingIfaceTest, IGN_UTILS_TEST_DISABLED_ON_WIN32(GetEngine))

Checklist

  • Signed all commits for DCO
  • Added a screen capture or video to the PR description that demonstrates the fix (as needed)
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • Updated Bazel files (if adding new files). Created an issue otherwise.
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Signed-off-by: miguelgonrod <miguelgonrod2004@gmail.com>
@github-actions github-actions Bot added the 🏯 fortress Ignition Fortress label Apr 29, 2026
@miguelgonrod miguelgonrod self-assigned this Apr 29, 2026
Signed-off-by: miguelgonrod <miguelgonrod2004@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.67%. Comparing base (6ea5ede) to head (0a84007).
⚠️ Report is 37 commits behind head on ign-rendering6.

Additional details and impacted files
@@                Coverage Diff                 @@
##           ign-rendering6    #1284      +/-   ##
==================================================
+ Coverage           79.60%   79.67%   +0.06%     
==================================================
  Files                 146      143       -3     
  Lines               13445    13992     +547     
==================================================
+ Hits                10703    11148     +445     
- Misses               2742     2844     +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-project-automation github-project-automation Bot moved this from Inbox to In review in Core development Apr 29, 2026
@iche033
Copy link
Copy Markdown
Contributor

iche033 commented Apr 30, 2026

The checks are all green now. Is this ready for merge?

@miguelgonrod miguelgonrod marked this pull request as ready for review May 1, 2026 13:14
@miguelgonrod miguelgonrod merged commit c39b130 into gazebosim:ign-rendering6 May 1, 2026
10 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in Core development May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏯 fortress Ignition Fortress

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants