Run more tests with ogre2 (backport #1263)#1270
Run more tests with ogre2 (backport #1263)#1270mergify[bot] wants to merge 3 commits intogz-rendering9from
Conversation
Comment why Text_TEST is skipped for ogre2 Signed-off-by: Steve Peters <scpeters@intrinsic.ai> (cherry picked from commit f44e3ef)
|
one of the tests is failing on 22.04 CI, so I expect it would also fail on 22.04 if backported to Harmonic, which raises questions for me about whether to disable CI on 22.04 or disable the test, or to be tricky and try to detect 22.04 and disable the test for that distro only |
|
I think the easiest thing to do is probably just disable the RenderTarget unit test for ogre2 with a note saying that it fails on jammy. |
that is an option, but Harmonic uses 24.04 with Jazzy, and 22.04 will be EOL next year, so I want to at least raise the question of when we should drop 22.04 support rather than reduce test coverage on 24.04 |
🦟 Bug fix
Part of #1235
Summary
There are several tests that use
CHECK_SUPPORTED_ENGINE("ogre")to only run withogre, and notogre2, but there are no comments about why this limitation is in place. This adds"ogre2"to each of these calls to see if the tests will actually pass with ogre2, and if not I will add comments explaining why.Checklist
codecheckpassed (See contributing)Generated-by: Remove this if GenAI was not used.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.Backports: If this is a backport, please use Rebase and Merge instead.
This is an automatic backport of pull request #1263 done by [Mergify](https://mergify.com).