Skip to content

Run more tests with ogre2 (backport #1263)#1270

Open
mergify[bot] wants to merge 3 commits intogz-rendering9from
mergify/bp/gz-rendering9/pr-1263
Open

Run more tests with ogre2 (backport #1263)#1270
mergify[bot] wants to merge 3 commits intogz-rendering9from
mergify/bp/gz-rendering9/pr-1263

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Apr 12, 2026

🦟 Bug fix

Part of #1235

Summary

There are several tests that use CHECK_SUPPORTED_ENGINE("ogre") to only run with ogre, and not ogre2, but there are no comments about why this limitation is in place. This adds "ogre2" to each of these calls to see if the tests will actually pass with ogre2, and if not I will add comments explaining why.

Checklist

  • Signed all commits for DCO
  • Added a screen capture or video to the PR description that demonstrates the fix (as needed)
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • Updated Bazel files (if adding new files). Created an issue otherwise.
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Backports: If this is a backport, please use Rebase and Merge instead.


This is an automatic backport of pull request #1263 done by [Mergify](https://mergify.com).

Comment why Text_TEST is skipped for ogre2

Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
(cherry picked from commit f44e3ef)
@mergify mergify Bot requested a review from iche033 as a code owner April 12, 2026 05:33
@github-actions github-actions Bot added the 🏛️ ionic Gazebo Ionic label Apr 12, 2026
@mergify mergify Bot mentioned this pull request Apr 12, 2026
11 tasks
@azeey azeey requested a review from scpeters May 5, 2026 21:01
@scpeters
Copy link
Copy Markdown
Member

scpeters commented May 5, 2026

one of the tests is failing on 22.04 CI, so I expect it would also fail on 22.04 if backported to Harmonic, which raises questions for me about whether to disable CI on 22.04 or disable the test, or to be tricky and try to detect 22.04 and disable the test for that distro only

@iche033
Copy link
Copy Markdown
Contributor

iche033 commented May 5, 2026

I think the easiest thing to do is probably just disable the RenderTarget unit test for ogre2 with a note saying that it fails on jammy.

@scpeters
Copy link
Copy Markdown
Member

scpeters commented May 5, 2026

I think the easiest thing to do is probably just disable the RenderTarget unit test for ogre2 with a note saying that it fails on jammy.

that is an option, but Harmonic uses 24.04 with Jazzy, and 22.04 will be EOL next year, so I want to at least raise the question of when we should drop 22.04 support rather than reduce test coverage on 24.04

@azeey azeey moved this from Inbox to In review in Core development May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

3 participants