Skip to content

Enable WireBox_TEST for ogre2#1267

Merged
scpeters merged 2 commits intomainfrom
scpeters/enable_wirebox_test
Apr 11, 2026
Merged

Enable WireBox_TEST for ogre2#1267
scpeters merged 2 commits intomainfrom
scpeters/enable_wirebox_test

Conversation

@scpeters
Copy link
Copy Markdown
Member

@scpeters scpeters commented Apr 11, 2026 •
edited
Loading

🦟 Bug fix

Follow-up to #1263

Summary

I just noticed that the WireBox_TEST is not being run for any versions of ogre. I tried enabling it both both versions of ogre in 36d9532, and it passes for ogre2 but fails for ogre, so I've just enabled it for ogre2.

Checklist

  • Signed all commits for DCO
  • Added a screen capture or video to the PR description that demonstrates the fix (as needed)
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • Updated Bazel files (if adding new files). Created an issue otherwise.
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Backports: If this is a backport, please use Rebase and Merge instead.

@scpeters
Enable WireBox_TEST
36d9532 
Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
@scpeters
redisable for ogre
773c83b 
Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
@scpeters scpeters changed the title Enable WireBox_TEST Enable WireBox_TEST for ogre2 Apr 11, 2026
@scpeters scpeters marked this pull request as ready for review April 11, 2026 19:32
@scpeters scpeters requested a review from iche033 as a code owner April 11, 2026 19:32
@github-project-automation github-project-automation Bot moved this from Inbox to In review in Core development Apr 11, 2026
@scpeters scpeters merged commit b209d47 into main Apr 11, 2026
11 of 12 checks passed
@scpeters scpeters deleted the scpeters/enable_wirebox_test branch April 11, 2026 23:08
@github-project-automation github-project-automation Bot moved this from In review to Done in Core development Apr 11, 2026
@scpeters
Copy link
Copy Markdown
Member Author

scpeters commented Apr 11, 2026

https://github.com/Mergifyio backport gz-rendering10

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 11, 2026 •
edited
Loading

backport gz-rendering10

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Apr 11, 2026
@scpeters @mergify
Enable WireBox_TEST for ogre2 (#1267)
da9b236 
Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
(cherry picked from commit b209d47)
@mergify mergify Bot mentioned this pull request Apr 11, 2026
Merged
11 tasks
scpeters added a commit that referenced this pull request Apr 12, 2026
@scpeters
Enable WireBox_TEST for ogre2 (#1267)
9922878 
Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
(cherry picked from commit b209d47)
@scpeters
Copy link
Copy Markdown
Member Author

scpeters commented Apr 12, 2026

https://github.com/Mergifyio backport gz-rendering9

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 12, 2026 •
edited
Loading

backport gz-rendering9

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Apr 12, 2026
@scpeters @mergify
Enable WireBox_TEST for ogre2 (#1267)
583441b 
Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
(cherry picked from commit b209d47)
@mergify mergify Bot mentioned this pull request Apr 12, 2026
Merged
11 tasks
scpeters added a commit that referenced this pull request Apr 13, 2026
@scpeters
Enable WireBox_TEST for ogre2 (#1267)
8800a6e 
Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
(cherry picked from commit b209d47)
@scpeters
Copy link
Copy Markdown
Member Author

scpeters commented Apr 13, 2026

https://github.com/Mergifyio backport gz-rendering8

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 13, 2026 •
edited
Loading

backport gz-rendering8

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Apr 13, 2026
@scpeters @mergify
Enable WireBox_TEST for ogre2 (#1267)
6a7725a 
Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
(cherry picked from commit b209d47)
@mergify mergify Bot mentioned this pull request Apr 13, 2026
Merged
11 tasks
scpeters added a commit that referenced this pull request Apr 13, 2026
@scpeters
Enable WireBox_TEST for ogre2 (#1267)
ad03d93 
Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
(cherry picked from commit b209d47)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iche033 iche033 iche033 approved these changes

Assignees

No one assigned

Labels

🎡 rotary

Projects

Core development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scpeters @iche033 @azeey