feat: support dynamic Peertube source icons via grayjay-plugin-peertube implementation#3297
Open
geco wants to merge 2 commits into
Open
feat: support dynamic Peertube source icons via grayjay-plugin-peertube implementation#3297geco wants to merge 2 commits into
geco wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Proposal (Android)
Title
feat: support dynamic Peertube source icons via grayjay-plugin-peertube implementation
Description
Currently, source icons are static and derived solely from the
iconUrldefined in the plugin's configuration JSON. This prevents plugins from displaying icons that are dynamically configured on the instance side (e.g., custom branding on a PeerTube instance).This PR implements a bridge that allows the Android app to request a dynamic icon by invoking a
getIcon()method within the plugin's JavaScript implementation.Changes
executeString()inV8Plugin.ktto provide a convenient way to invoke JS functions and retrieve string results.getDynamicIcon(id)inStatePlugins.ktto handle the asynchronous retrieval of the icon URL from the plugin instance on a background thread.SourceHeaderView.ktto use a coroutine that attempts to load the dynamic icon first.getIcon()or the call fails, it reverts to the staticabsoluteIconUrlderived from the JSON config.Use Case: PeerTube
This feature is primarily designed to support the PeerTube plugin, enabling it to fetch and display the specific icon configured on the target PeerTube instance.
The plugin-side implementation can be reviewed here:
👉 futo-org/grayjay-plugin-peertube#3
Testing
getIcon) still display their static icons without any regressions.