fix: resolve team member names via /person/infos#8
Merged
Conversation
Bump flashduty-sdk to 5405a3a which fixes member enrichment for member-level app keys. Team list and get now show member names instead of raw IDs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
team listandteam getshowing raw member IDs instead of names/person/infosfor member enrichment, which works with member-level app keyscreator_namein team detailTest plan
go test -race ./...passesflashduty team get --id <id>shows member names and emailsflashduty team listshows member names in MEMBERS columnflashduty team get --id <id> --jsonreturns enriched members