Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ test = [
ci = [
"feast[test, aws, azure, cassandra, clickhouse, couchbase, delta, docling, duckdb, elasticsearch, faiss, gcp, ge, go, grpcio, hazelcast, hbase, ibis, image, k8s, mcp, milvus, mongodb, mssql, mysql, openlineage, opentelemetry, oracle, spark, trino, postgres, pytorch, qdrant, rag, ray, redis, singlestore, snowflake, sqlite_vec]",
"build",
"virtualenv==20.23.0",
"virtualenv==20.36.1",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Lock files not regenerated: CI will still install virtualenv==20.23.0

The pyproject.toml was updated to virtualenv==20.36.1, but all CI lock files still pin virtualenv==20.23.0. Since CI uses uv pip sync with these lock files (via make install-python-dependencies-ci at Makefile:106-116), the version bump has no effect in CI or local dev environments. The stale lock files are: sdk/python/requirements/py3.10-ci-requirements.txt:6191, sdk/python/requirements/py3.11-ci-requirements.txt:6434, sdk/python/requirements/py3.12-ci-requirements.txt:6421, and pixi.lock:2350. Running make lock-python-dependencies-all is needed to regenerate them.

Prompt for agents
The pyproject.toml now specifies virtualenv==20.36.1 but the CI lock files (sdk/python/requirements/py3.{10,11,12}-ci-requirements.txt and pixi.lock) still pin virtualenv==20.23.0. Since CI environments install from the lock files via uv pip sync (see Makefile lines 106-116), the version bump will not take effect until the lock files are regenerated. Run `make lock-python-dependencies-all` (Makefile:133) to regenerate all requirement lock files, and also update pixi.lock to reflect the new version.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

"dbt-artifacts-parser",
"ruff>=0.8.0",
"mypy-protobuf>=3.1",
Expand Down
Loading