Skip to content

[Accton][Minipack3BAM] Introduce platform support and NETLAKE-2 integration#1067

Closed
brandonchuang wants to merge 1 commit intofacebook:mainfrom
brandonchuang:nl2_mp3bam
Closed

[Accton][Minipack3BAM] Introduce platform support and NETLAKE-2 integration#1067
brandonchuang wants to merge 1 commit intofacebook:mainfrom
brandonchuang:nl2_mp3bam

Conversation

@brandonchuang
Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run
    clang-format.........................................(no files to check)Skipped
    shellcheck...........................................(no files to check)Skipped
    shfmt................................................(no files to check)Skipped
    trim trailing whitespace.................................................Passed
    fix end of files.........................................................Passed
    check yaml...........................................(no files to check)Skipped
    check json...............................................................Passed
    check for merge conflicts................................................Passed
    ruff check...........................................(no files to check)Skipped
    ruff format..........................................(no files to check)Skipped

Summary:

This PR introduces support for the Minipack3BAM platform by porting and adapting configurations from the existing Minipack3BA platform. Key updates include the integration of NETLAKE-2 I2C device mappings and necessary kernel configuration adjustments.

Kernel Configuration:

  • Enabled CONFIG_SENSORS_INA2XX and CONFIG_SENSORS_SPD5118 for power and memory monitoring.

Platform Manager:

  • Standardized CPU bus naming using the virtual bus "CPU_BUS".
  • Implemented versionedPmUnitConfigs for NETLAKE-2 hardware identification.
  • Updated pmUnitConfig, symbolicLinkToDevicePath, and CPU_CORE_TEMP sysfs paths to align with NETLAKE-2 I2C topology.

Sensor Service:

  • Migrated "NETLAKE" sensor definitions and sysfs paths to support the new hardware layout.

Firmware Utility:

  • Updated fw_util BIOS upgrade logic to support NETLAKE-2 specific flash sequences.

No Changes Required:

bsp_tests.json, fan_service.json, led_manager.json.

Test Plan:

Platform Manager:

Sensor Service:

Fan Service:

weutil:

fw_util:

Data Corral Service:

bsp_tests:

…ration

Summary:
This PR introduces support for the Minipack3BAM platform by porting and adapting configurations
from the existing Minipack3BA platform. Key updates include the integration of NETLAKE-2
I2C device mappings and necessary kernel configuration adjustments.

Kernel Configuration:
Enabled CONFIG_SENSORS_INA2XX and CONFIG_SENSORS_SPD5118 for power and memory monitoring.

Platform Manager:
- Standardized CPU bus naming using the virtual bus "CPU_BUS".
- Implemented versionedPmUnitConfigs for NETLAKE-2 hardware identification.
- Updated pmUnitConfig, symbolicLinkToDevicePath, and CPU_CORE_TEMP sysfs paths to align with NETLAKE-2 I2C topology.

Sensor Service:
- Migrated "NETLAKE" sensor definitions and sysfs paths to support the new hardware layout.

Firmware Utility:
- Updated fw_util BIOS upgrade logic to support NETLAKE-2 specific flash sequences.

No Changes Required: bsp_tests.json, fan_service.json, led_manager.json.

Test Plan:
Platform Manager:
  Executed platform_manager and platform_manager_hw_test on Minipack3BAM; all functional logs validated and tests passed.
Sensor Service:
  Verified initialization of universal and versioned sensors via sensor_service, sensor_service_hw_test, and sensor_service_client.
Fan Service:
  Confirmed PWM control and RPM feedback via fan_service and fan_service_hw_test.
weutil:
  Executed weutil to verify baseboard and module EEPROM information and weutil_hw_test; all items passed.
fw_util:
  Executed fw_util to list and verify firmware versions of CPLDs and other programmable devices, including fw_util_hw_test; all items passed.
Data Corral Service:
  Executed data_corral_service and verified SCM/Fru presence and LED status monitoring.
bsp_tests:
  Executed bsp_tests to ensure kernel module stability and I2C/PMBus driver robustness under load.
@brandonchuang brandonchuang requested a review from a team as a code owner April 9, 2026 07:56
@meta-cla meta-cla bot added the CLA Signed label Apr 9, 2026
@github-actions github-actions bot added the accton label Apr 9, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync bot commented Apr 10, 2026

@tao-ren has imported this pull request. If you are a Meta employee, you can view this in D100271739.

@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync bot commented Apr 13, 2026

@tao-ren merged this pull request in e60229e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant