[Accton][Minipack3BAM] Introduce platform support and NETLAKE-2 integration#1067
Closed
brandonchuang wants to merge 1 commit intofacebook:mainfrom
Closed
[Accton][Minipack3BAM] Introduce platform support and NETLAKE-2 integration#1067brandonchuang wants to merge 1 commit intofacebook:mainfrom
brandonchuang wants to merge 1 commit intofacebook:mainfrom
Conversation
…ration Summary: This PR introduces support for the Minipack3BAM platform by porting and adapting configurations from the existing Minipack3BA platform. Key updates include the integration of NETLAKE-2 I2C device mappings and necessary kernel configuration adjustments. Kernel Configuration: Enabled CONFIG_SENSORS_INA2XX and CONFIG_SENSORS_SPD5118 for power and memory monitoring. Platform Manager: - Standardized CPU bus naming using the virtual bus "CPU_BUS". - Implemented versionedPmUnitConfigs for NETLAKE-2 hardware identification. - Updated pmUnitConfig, symbolicLinkToDevicePath, and CPU_CORE_TEMP sysfs paths to align with NETLAKE-2 I2C topology. Sensor Service: - Migrated "NETLAKE" sensor definitions and sysfs paths to support the new hardware layout. Firmware Utility: - Updated fw_util BIOS upgrade logic to support NETLAKE-2 specific flash sequences. No Changes Required: bsp_tests.json, fan_service.json, led_manager.json. Test Plan: Platform Manager: Executed platform_manager and platform_manager_hw_test on Minipack3BAM; all functional logs validated and tests passed. Sensor Service: Verified initialization of universal and versioned sensors via sensor_service, sensor_service_hw_test, and sensor_service_client. Fan Service: Confirmed PWM control and RPM feedback via fan_service and fan_service_hw_test. weutil: Executed weutil to verify baseboard and module EEPROM information and weutil_hw_test; all items passed. fw_util: Executed fw_util to list and verify firmware versions of CPLDs and other programmable devices, including fw_util_hw_test; all items passed. Data Corral Service: Executed data_corral_service and verified SCM/Fru presence and LED status monitoring. bsp_tests: Executed bsp_tests to ensure kernel module stability and I2C/PMBus driver robustness under load.
Contributor
|
@tao-ren has imported this pull request. If you are a Meta employee, you can view this in D100271739. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runclang-format.........................................(no files to check)Skipped
shellcheck...........................................(no files to check)Skipped
shfmt................................................(no files to check)Skipped
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check json...............................................................Passed
check for merge conflicts................................................Passed
ruff check...........................................(no files to check)Skipped
ruff format..........................................(no files to check)Skipped
Summary:
This PR introduces support for the Minipack3BAM platform by porting and adapting configurations from the existing Minipack3BA platform. Key updates include the integration of NETLAKE-2 I2C device mappings and necessary kernel configuration adjustments.
Kernel Configuration:
Platform Manager:
Sensor Service:
Firmware Utility:
No Changes Required:
bsp_tests.json, fan_service.json, led_manager.json.
Test Plan:
Platform Manager:
[mp3bam_nl2_log] platform_manager.txt
[mp3bam_nl2_log] platform_manager_hw_test.txt
Sensor Service:
[mp3bam_nl2_log] sensor_service.txt
[mp3bam_nl2_log] sensor_service_hw_test.txt
[mp3bam_nl2_log] sensor_service_client.txt
Fan Service:
[mp3bam_nl2_log] fan_service.txt
[mp3bam_nl2_log] fan_service_hw_test.txt
weutil:
[mp3bam_nl2_log] weutil.txt
[mp3bam_nl2_log] weutil_hw_test.txt
fw_util:
[mp3bam_nl2_log] fw_util.txt
[mp3bam_nl2_log] fw_util_hw_test.txt
Data Corral Service:
[mp3bam_nl2_log] data_corral_service.txt
[mp3bam_nl2_log] data_corral_service_hw_test.txt
bsp_tests:
[mp3bam_nl2_log] bsp_tests.txt