Skip to content

Support class component (HOC)#11

Open
halitogunc wants to merge 7 commits into
f:masterfrom
halitogunc:support-class-components
Open

Support class component (HOC)#11
halitogunc wants to merge 7 commits into
f:masterfrom
halitogunc:support-class-components

Conversation

@halitogunc

@halitogunc halitogunc commented Aug 19, 2019

Copy link
Copy Markdown

This PR enables react-wait to use in a class component via injected prop #8 and also contains some refactoring stuffs that I wanted to request your comments. @f

I tested all functionality on my machine and it worked, but I didn't prepare test cases yet. This is why it is work in progress. Since tests were added, it is not the case anymore.

Waiting for the review :shipit:

@codecov

codecov Bot commented Aug 19, 2019

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e2ad406) to head (e7c30de).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #11   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         5    +3     
  Lines           23        35   +12     
  Branches         2         4    +2     
=========================================
+ Hits            23        35   +12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@halitogunc halitogunc changed the title [WIP] Support class component (HOC) Support class component (HOC) Aug 22, 2019
@halitogunc

Copy link
Copy Markdown
Author

just sending you a kindly reminder @f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant