[build-tools] Skip embedded bundle upload for dev client builds#3940
Open
gwdp wants to merge 1 commit into
Open
[build-tools] Skip embedded bundle upload for dev client builds#3940gwdp wants to merge 1 commit into
gwdp wants to merge 1 commit into
Conversation
gwdp
force-pushed
the
gwdp/skip-embedded-upload-dev-builds
branch
from
66f34db to
4bd4dd4
Compare
|
✅ Thank you for adding the changelog entry! |
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3940 +/- ##
==========================================
+ Coverage 59.28% 59.28% +0.01%
==========================================
Files 935 935
Lines 41093 41096 +3
Branches 8660 8661 +1
==========================================
+ Hits 24356 24359 +3
Misses 16643 16643
Partials 94 94 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dev client builds don't embed a bundle. We only skipped the upload for iOS simulators, so other dev builds warned about a missing bundle. This skips all dev client builds.
Test plan
Added a unit test. CI passes.