Skip to content

[build-tools] Remove updateEnv merge-order Datadog log#3935

Draft
sjchmiela wants to merge 1 commit into
mainfrom
stanley/remove-update-env-datadog-log
Draft

[build-tools] Remove updateEnv merge-order Datadog log#3935
sjchmiela wants to merge 1 commit into
mainfrom
stanley/remove-update-env-datadog-log

Conversation

@sjchmiela

Copy link
Copy Markdown
Contributor

Summary

  • remove the temporary Datadog log that compared old and new updateEnv merge-order results
  • keep the new updateEnv merge order behavior unchanged
  • remove the log-specific test assertions

Test plan

  • yarn fmt packages/build-tools/src/context.ts packages/build-tools/src/tests/context.test.ts
  • yarn --cwd packages/build-tools jest-unit src/tests/context.test.ts
  • yarn --cwd packages/build-tools typecheck

This is intended to be merged after we confirm the migration looks good in Datadog.

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.19%. Comparing base (8a66d38) to head (93346e7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3935      +/-   ##
==========================================
- Coverage   59.21%   59.19%   -0.01%     
==========================================
  Files         935      935              
  Lines       41093    41075      -18     
  Branches     8651     8648       -3     
==========================================
- Hits        24329    24311      -18     
  Misses      16670    16670              
  Partials       94       94              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant