test: add regression guard for nil-error invariant on failure conditions#24
Closed
Copilot wants to merge 2 commits into
Closed
test: add regression guard for nil-error invariant on failure conditions#24Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
3 tasks
…with nil error Co-authored-by: costela <94699+costela@users.noreply.github.com> Agent-Logs-Url: https://github.com/exaring/hoglet/sessions/1eef0e08-4cf1-4cc3-94e6-176f2fead113
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on simplifying failure conditions with nil check
test: add regression guard for nil-error invariant on failure conditions
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nil-check guard (
err != nil && c.options.isFailure(err)) inhoglet.goestablishes a contract that custom failure conditions are never invoked withnilerrors, but nothing enforced this at the test level.Changes
TestCircuit_failure_condition_never_called_with_nil): registers a failure condition that panics onnil, wraps a function returning a nil error, and asserts no panic — any removal of the nil guard will cause an immediate, obvious failure.⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.