Test Submission #4
Closed
shirishaKodimala wants to merge 4 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements room setup and lobby functionality: host designation, room code validation, auto-polling lobby, and host-only game start.
Changes
Backend
backend/src/models/game.ts— AddedhostIdfield toRoomandRoomSnapshot; extendedRoomStatusto include"playing"backend/src/services/roomStore.ts— Creator is now automatically set ashostIdon room creation;hostIdexposed in snapshots; newstartGame()service validates host + 2+ players before transitioning room to"playing"backend/src/api/schemas.ts— AddedstartRoomSchema;roomCodeParamsSchemanow rejects empty codes with.min(1)backend/src/api/rooms.ts— NewPOST /rooms/:code/startendpoint with 403 (not host) / 400 (not enough players) error handling; improved join error message to "Room not found. Please check the code and try again"Frontend
frontend/src/services/api.ts— AddedstartGame()API method; updatedRoomSnapshottype withhostIdand"playing"statusfrontend/src/state/roomStore.ts— AddedstartGame()method to RoomStore classfrontend/src/pages/LobbyPage.tsx— Auto-polls every 2s viasetInterval; shows "Host" badge on creator; start button disabled for non-hosts / < 2 players; auto-redirects to/gamewhen status becomes"playing"frontend/src/pages/JoinRoomPage.tsx— Client-side validation rejects empty room codes with "Please enter a room code"Specs
plan.md,research.md,data-model.md,contracts/api.md,quickstart.md,tasks.mdTesting
tsc --noEmitspecs/001-room-setup-lobby/quickstart.mdfor manual testing scenariosContributor