Skip to content

feat: test coverage#27

Draft
fcsondheim wants to merge 8 commits into
mainfrom
test-coverage
Draft

feat: test coverage#27
fcsondheim wants to merge 8 commits into
mainfrom
test-coverage

Conversation

@fcsondheim
Copy link
Copy Markdown
Collaborator

@fcsondheim fcsondheim commented May 27, 2026 •
edited
Loading

What

  • Add client tests for executeGraphQLQuery, object fetch helpers, dynamic fields, and assembly owner/energy-source GraphQL handling.
  • Add coverage for constants, transforms, wallet feature guards, wallet utilities, and error parsing.
  • Remove obsolete ABI / forwarder / callFrom error definitions that do not apply to Sui
  • Require object-shaped Wallet Standard features for sponsored transaction support
  • Remove array-shaped wallet feature handling and the duplicate getSponsoredTransactionMethod helper
  • Simplify useSponsoredTransaction to resolve the sponsored transaction function directly from the connected wallet feature
  • Update CI to run dapp-kit coverage and report Vitest coverage on PRs

Why

Testing observability

Copilot AI review requested due to automatic review settings May 27, 2026 17:11
@fcsondheim fcsondheim marked this pull request as draft May 27, 2026 17:11
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 27, 2026 •
edited
Loading

Coverage Report for @evefrontier/dapp-kit

Status Category Percentage Covered / Total
🔵 Lines 92.95% 488 / 525
🔵 Statements 93.01% 506 / 544
🔵 Functions 88.57% 93 / 105
🔵 Branches 79.88% 286 / 358
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/libs/dapp-kit/utils/errors.ts 100% 100% 100% 100%
packages/libs/dapp-kit/wallet/features.ts 100% 100% 100% 100%
packages/libs/dapp-kit/wallet/utils.ts 100% 100% 100% 100%
packages/libs/dapp-kit/wallet/__tests__/testHelpers.ts 75% 100% 66.66% 100% 5-8
Generated in workflow #59 for commit 2031e9c by the Vitest Coverage Report Action

Copilot AI reviewed May 27, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@fcsondheim fcsondheim force-pushed the test-coverage branch 2 times, most recently from 7388e81 to c1487bc Compare May 28, 2026 16:34
@fcsondheim fcsondheim changed the base branch from main to fix-pkg-naming May 28, 2026 16:34
Base automatically changed from fix-pkg-naming to main May 29, 2026 09:54
@fcsondheim fcsondheim marked this pull request as ready for review May 29, 2026 13:28
@fcsondheim fcsondheim requested a review from Copilot May 29, 2026 13:29
Copilot AI reviewed May 29, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Comment thread packages/libs/dapp-kit/wallet/features.ts
@fcsondheim fcsondheim marked this pull request as draft May 29, 2026 16:22
ccp-bofai
ccp-bofai approved these changes May 29, 2026
View reviewed changes
Copy link
Copy Markdown

@ccp-bofai ccp-bofai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ccp-bofai ccp-bofai ccp-bofai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fcsondheim @ccp-bofai