client/v3: check lease freshness before serving cached reads, fix EvictRange bug#21589
client/v3: check lease freshness before serving cached reads, fix EvictRange bug#21589thecitymouse wants to merge 2 commits intoetcd-io:mainfrom
Conversation
Signed-off-by: thecitymouse <leungke+1@oregonstate.edu>
Signed-off-by: thecitymouse <leungke+1@oregonstate.edu>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: thecitymouse The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @thecitymouse. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The leasing layer claims linearizable reads via lease-based escape, but never actually checks the lease is valid before serving from cache. Adds the missing freshness check. Cannot be fully safe under unbounded clock drift, which matches what the package docs already imply about lease-based mechanisms.
Also fixes
EvictRangeusing the loop parameterkeyinstead of the loop variablek.Test case from @upamanyus in #19091 / #19092.
Fixes #19091