Skip to content

client/v3: check lease freshness before serving cached reads, fix EvictRange bug#21589

Open
thecitymouse wants to merge 2 commits intoetcd-io:mainfrom
thecitymouse:fix-lease-expiration
Open

client/v3: check lease freshness before serving cached reads, fix EvictRange bug#21589
thecitymouse wants to merge 2 commits intoetcd-io:mainfrom
thecitymouse:fix-lease-expiration

Conversation

@thecitymouse
Copy link
Copy Markdown

The leasing layer claims linearizable reads via lease-based escape, but never actually checks the lease is valid before serving from cache. Adds the missing freshness check. Cannot be fully safe under unbounded clock drift, which matches what the package docs already imply about lease-based mechanisms.

Also fixes EvictRange using the loop parameter key instead of the loop variable k.

Test case from @upamanyus in #19091 / #19092.

Fixes #19091

Signed-off-by: thecitymouse <leungke+1@oregonstate.edu>
Signed-off-by: thecitymouse <leungke+1@oregonstate.edu>
@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: thecitymouse
Once this PR has been reviewed and has the lgtm label, please assign siyuanfoundation for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown

Hi @thecitymouse. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Client lease library does not check for expiration

2 participants