feat(newsletters): complete HTTP layer (AdonisJS)#88
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
…utes Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ps for frontend gating
Supports scheduling failed sends before they are eligible to be claimed again. Co-authored-by: Cursor <cursoragent@cursor.com>
…laim, backoff, first-N auto-pause). Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…t allowlist. Co-authored-by: Cursor <cursoragent@cursor.com>
- pretest: run the build before `node --test` so the newsletter engine contract test can import the compiled service. It loads from build/, which CI never produced (only the author's stale local build existed), causing ERR_MODULE_NOT_FOUND on the Node 24 job. - eslint --fix across the newsletter HTTP layer (prettier formatting), plus manual eqeqeq fixes — the `== null` idioms are expanded to explicit null/undefined checks to preserve their null-or-undefined semantics — and de-shadow the `router` parameter in registerNewsletterAdminRoutes (the module-level router is already in scope at the call site). - prettier formatting for scripts/copy-build-assets.mjs. Local: ESLint clean, Prettier clean, 514 node + 15 Japa tests, 0 failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Brings escalated-adonis from engine-only to full newsletter parity. Adonis had the tables + Lucid models + 6 services but no HTTP layer — this adds admin/public/webhook controllers, the dispatch ace command, enabled gate, permission enforcement, and tests.
Part of the full-parity program (mirrors the Laravel + NestJS references against
escalated/docs/superpowers/specs/2026-06-02-newsletter-http-parity-contract.md).Added
start/routes.tsunder/newsletterswith correct ordering (static segments before/:newsletter) and exactescalated.admin.newsletters.*route names.escalated/n+ ESP webhook controller (postmark/mailgun/ses/sendgrid) underescalated/webhooks/newsletter, both behindEnsureNewslettersEnabledmiddleware.node ace escalated:newsletters:dispatch(plan due + dispatch batch).ensure_newsletters_enabledmiddleware (default off).newsletters.manage(admin actions) /newsletters.send(store-when-sending + test-send) viaNewsletterPermissionService; seeded in the permission seed command + DB seeder.Verification
npm run build: PASS. Full suite: 509 node + 15 Japa, 0 failures.Host-setup note
Adonis Shield CSRF is host-configured, so the host app must exempt
POST escalated/n/u/:token(unsubscribe) from CSRF — documented in the command output. (Same public-unsubscribe behavior as the Laravel reference, where the plugin exempts it directly.)