Analysis: Use stricter function terminator checks in prologue detection#135
Merged
Conversation
Owner
|
Thanks! |
freeqaz
added a commit
to freeqaz/jeff
that referenced
this pull request
Jun 9, 2026
Cherry-picked from encounter/decomp-toolkit aa635e1 (encounter#135, by bluisblu). Swaps the prologue-split heuristic from is_end_of_seq to a stricter is_function_terminator (blr / b / rfi / addi r1,r1 / lwz r1,d(rN!=r1)), so two prologue-like sequences are only split when a real function terminator separates them. Applies cleanly to jeff's prologue loop; builds green. Skipped the companion upstream jump-table clamp (89106d0): jeff already clamps independently (analysis/mod.rs: available.min(requested)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #111
Tested against GQPE78 and R42P69 with identical
dol infooutput.