config: restore missing hand control gains for v1.0#63
Merged
kou merged 1 commit intoMay 29, 2026
Conversation
GitHub fixes enactic/openarm_ros2#92 The ROS 2 demo fails with an error, so this fixes it. Restored what was lost in commit enactic@d82e87d#diff-140e377051fc1947b0dbd8a0f32b52cb04a3cff22f517706e50430bce0d3576eL42-L45 . Thanks for the report, fjesp!!!
There was a problem hiding this comment.
Pull request overview
This PR restores missing hand control gain configuration for OpenArm v1.0, addressing ROS 2 demo failures caused by control_gains['hand'] being referenced by the URDF xacro without a corresponding YAML entry.
Changes:
- Adds
handproportional and derivative gains to the v1.0 arm control gains config.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub fixes enactic/openarm_ros2#92
The ROS 2 demo fails with an error, so this fixes it.
Restored what was lost in commit d82e87d#diff-140e377051fc1947b0dbd8a0f32b52cb04a3cff22f517706e50430bce0d3576eL42-L45 .
Thanks for the report, fjesp!!!