Cleanup fallback codepaths for older Ember versions#1298
Open
Cleanup fallback codepaths for older Ember versions#1298
Conversation
Member
rwjblue
commented
Dec 16, 2022
rwjblue
commented
- Remove supporting code for Ember < 4
- Remove guards for supporting older Ember versions
chriskrycho
approved these changes
Dec 16, 2022
chriskrycho
reviewed
Dec 16, 2022
chriskrycho
approved these changes
Dec 16, 2022
rwjblue
force-pushed
the
older-ember-cleanup
branch
from
cff45b4 to
7b895b7
Compare
Contributor
|
This'll need a rebase/merge courtesy of merging #1299. I'll tackle it on Monday. |
# Conflicts: # tests/unit/dom/blur-test.js # tests/unit/dom/click-test.js # tests/unit/dom/double-click-test.js # tests/unit/dom/fill-in-test.js # tests/unit/dom/focus-test.js # tests/unit/dom/tab-test.js # tests/unit/dom/tap-test.js
Contributor
|
Okay, that works… but now we have test failures because something isn't quite right in e34264e, I think. Will poke at it… after getting a whole bunch more deck-clearing done with Ember's types publishing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.