Merge pull request #2507 from johanrd/fix/2490

Post-merge review of #2490 (`template-no-outlet-outside-routes`)

Author: NullVoxPopuli

lib/rules/template-no-outlet-outside-routes.js

@@ -55,17 +55,20 @@ module.exports = {
 
     const routeTemplate = isRouteTemplate(filename);
 
-    return {
-      GlimmerMustacheStatement(node) {
-        if (node.path.type === 'GlimmerPathExpression' && node.path.original === 'outlet') {
-          if (!routeTemplate) {
-            context.report({
-              node,
-              messageId: 'noOutletOutsideRoutes',
-            });
-          }
+    function checkForOutlet(node) {
+      if (node.path.type === 'GlimmerPathExpression' && node.path.original === 'outlet') {
+        if (!routeTemplate) {
+          context.report({
+            node,
+            messageId: 'noOutletOutsideRoutes',
+          });
         }
-      },
+      }
+    }
+
+    return {
+      GlimmerMustacheStatement: checkForOutlet,
+      GlimmerBlockStatement: checkForOutlet,
     };
   },
 };

tests/lib/rules/template-no-outlet-outside-routes.js

@@ -25,6 +25,11 @@ ruleTester.run('template-no-outlet-outside-routes', rule, {
       filename: 'app/routes/foo.gts',
       code: '<template>{{outlet}}</template>',
     },
+    // Block form in GJS route templates — outlet is allowed
+    {
+      filename: 'app/routes/foo.gjs',
+      code: '<template>{{#outlet}}content{{/outlet}}</template>',
+    },
   ],
   invalid: [
     // Co-located component (explicit filename)
@@ -46,6 +51,13 @@ ruleTester.run('template-no-outlet-outside-routes', rule, {
       output: null,
       errors: [{ messageId: 'noOutletOutsideRoutes' }],
     },
+    // Block form in component
+    {
+      filename: 'app/components/my-component.gjs',
+      code: '<template>{{#outlet}}content{{/outlet}}</template>',
+      output: null,
+      errors: [{ messageId: 'noOutletOutsideRoutes' }],
+    },
   ],
 });
 
@@ -120,5 +132,12 @@ hbsRuleTester.run('template-no-outlet-outside-routes', rule, {
       output: null,
       errors: [{ messageId: 'noOutletOutsideRoutes' }],
     },
+    // Block form in component template
+    {
+      filename: 'app/components/foo/layout.hbs',
+      code: '{{#outlet}}content{{/outlet}}',
+      output: null,
+      errors: [{ messageId: 'noOutletOutsideRoutes' }],
+    },
   ],
 });