Merge pull request #2493 from johanrd/fix/2442

Post-merge review of #2442 (`template-no-inline-styles`)

Author: NullVoxPopuli

lib/rules/template-no-inline-styles.js

@@ -32,10 +32,9 @@ module.exports = {
           return;
         }
 
-        // If allowDynamicStyles is true, skip dynamic style values (MustacheStatement/ConcatStatement)
+        // If allowDynamicStyles is true, skip dynamic style values (MustacheStatement only)
         if (allowDynamicStyles) {
-          const valType = styleAttr.value?.type;
-          if (valType === 'GlimmerMustacheStatement' || valType === 'GlimmerConcatStatement') {
+          if (styleAttr.value?.type === 'GlimmerMustacheStatement') {
             return;
           }
         }

tests/lib/rules/template-no-inline-styles.js

@@ -21,5 +21,16 @@ ruleTester.run('template-no-inline-styles', rule, {
       output: null,
       errors: [{ messageId: 'noInlineStyles' }],
     },
+    {
+      code: '<template><div style="color:blue;margin-left:30px;"></div></template>',
+      output: null,
+      errors: [{ messageId: 'noInlineStyles' }],
+    },
+    {
+      // ConcatStatement should be invalid even with allowDynamicStyles (default true)
+      code: '<template><div style="{{foo}} bar"></div></template>',
+      output: null,
+      errors: [{ messageId: 'noInlineStyles' }],
+    },
   ],
 });