Merge pull request #2506 from johanrd/fix/2423

Post-merge review of #2423 (`template-no-action`)

Author: NullVoxPopuli

lib/rules/template-no-action.js

@@ -34,6 +34,8 @@ module.exports = {
       subExpression:
         'Do not use `action` as (action ...). Instead, use the `on` modifier and `fn` helper.',
       mustache: 'Do not use `action` in templates. Instead, use the `on` modifier and `fn` helper.',
+      modifier:
+        'Do not use `action` as an element modifier. Instead, use the `on` modifier and `fn` helper.',
     },
   },
 
@@ -49,19 +51,19 @@ module.exports = {
       },
 
       GlimmerMustacheStatement(node) {
-        // Skip if inside an attribute
-        let parent = node.parent;
-        while (parent) {
-          if (parent.type === 'GlimmerAttrNode') {
-            return;
-          }
-          parent = parent.parent;
+        if (isActionHelper(node)) {
+          context.report({
+            node,
+            messageId: 'mustache',
+          });
         }
+      },
 
+      GlimmerElementModifierStatement(node) {
         if (isActionHelper(node)) {
           context.report({
             node,
-            messageId: 'mustache',
+            messageId: 'modifier',
           });
         }
       },

tests/lib/rules/template-no-action.js

@@ -57,5 +57,31 @@ ruleTester.run('template-no-action', rule, {
         },
       ],
     },
+    {
+      code: `<template>
+        <button {{action "submit"}}>Submit</button>
+      </template>`,
+      output: null,
+      errors: [
+        {
+          message:
+            'Do not use `action` as an element modifier. Instead, use the `on` modifier and `fn` helper.',
+          type: 'GlimmerElementModifierStatement',
+        },
+      ],
+    },
+    {
+      code: `<template>
+        <input onclick={{action "foo"}}>
+      </template>`,
+      output: null,
+      errors: [
+        {
+          message:
+            'Do not use `action` in templates. Instead, use the `on` modifier and `fn` helper.',
+          type: 'GlimmerMustacheStatement',
+        },
+      ],
+    },
   ],
 });