Add experimental support for Spring Boot 4 and Spring Framework 7 in WebFlux#4489
Open
sergiofdezfernandez wants to merge 1 commit into
Open
Conversation
|
💚 CLA has been signed |
🤖 GitHub commentsJust comment with:
|
… Framework 7 in WebFlux instrumentation
11d559d to
5adbf2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds experimental support for Spring Boot 4 / Spring Framework 7 in the WebFlux instrumentation plugin by replacing all usages of the removed
HttpHeaders.get(Object)API withHttpHeaders.getValuesAsList(String), which exists with the same signature across Spring Framework 5.x, 6.x, and 7.x.Closes: Issue 4472
Background
In Spring Framework 6+,
org.springframework.http.HttpHeadersno longer extendsMultiValueMap<String, String>(and therefore no longer implementsMap). The inheritedMap.get(Object)method was removed in Spring 7. Our advice classes were compiled against Spring 5, so at runtime on Spring Boot 4 they threw:java.lang.NoSuchMethodError: 'java.util.List org.springframework.http.HttpHeaders.get(java.lang.Object)'
Checklist