Fix struct hack / flexible array member#660
Merged
Merged
Conversation
michaelortmann
pushed a commit
to michaelortmann/eggdrop
that referenced
this pull request
Oct 1, 2018
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by: michaelortmann
Patch by: michaelortmann
Fixes:
One-line summary:
Fix struct hack / flexible array member
Additional description (if needed):
The struct hack code is "new" in eggdrop and it fails on systems like Haiku alpha1/gcc 2.93.3:
Fix coredns.c:154: field data has incomplete typeThis general fix uses Macro AC_C_FLEXIBLE_ARRAY_MEMBER, see:
https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/C-Compiler.html
This fix also helps eggdrop to be C89 compatible.
#548 now also requires this patch, due to it also does struct hack.
please run misc/runautotools after merge
Test cases demonstrating functionality (if applicable):
a quick compile and run was fine