Adopt clang-tidy support from @score_cpp_policies by RSingh1511 · Pull Request #77 · eclipse-score/logging

RSingh1511 · 2026-03-25T06:27:27Z

Notes for Reviewer

Pre-Review Checklist for the PR Author

PR title is short, expressive and meaningful
Commits are properly organized
Relevant issues are linked in the References section
Tests are conducted
Unit tests are added

Checklist for the PR Reviewer

Commits are properly organized and messages are according to the guideline
Unit tests have been written for new behavior
Public API is documented
PR title describes the changes

Post-review Checklist for the PR Author

All open points are addressed and tracked via issues

References

Closes #

github-actions · 2026-03-25T06:28:09Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 70390681-84b5-41ef-af11-c3217ca2de42
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 6.631s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

rmaddikery · 2026-06-11T08:55:40Z

+
+exports_files(
+    ["linters.bzl"],
+    visibility = ["//visibility:public"],


visibility to the existing package should be sufficient and not public.

rmaddikery · 2026-06-11T08:56:27Z

 test:tsan --@score_cpp_policies//sanitizers/flags:sanitizer=tsan
 test:tsan --run_under=@score_cpp_policies//sanitizers:wrapper
+
+# Clang-tidy: bazel test --config=clang-tidy //score/mw/...


Suggested change

# Clang-tidy: bazel test --config=clang-tidy //score/mw/...

# Clang-tidy: bazel test --config=clang-tidy //score/...

rmaddikery · 2026-06-11T11:26:42Z

 bazel_dep(name = "score_tooling", version = "1.1.2")
 bazel_dep(name = "score_rust_policies", version = "0.0.3")

+# TODO(https://github.com/eclipse-score/baselibs/issues/266)


Suggested change

# TODO(https://github.com/eclipse-score/baselibs/issues/266)

# Due to incoming transitive deps from baselibs flatbuffers module.

# FIXME: To be removed after https://github.com/eclipse-score/baselibs/issues/266 is resolved

rmaddikery · 2026-06-16T13:33:31Z

+      - name: Run clang-tidy
+        # Scope limited to //score/mw/... because Rust/QNX targets are not yet
+        # validated against this configuration. Expand once they pass.
+        run: bazel test --config=clang-tidy --lockfile_mode=error //score/mw/log/... //score/datarouter/...


Include only cpp for now

bazel test --config=clang-tidy --lockfile_mode=error //score/mw/log/... //score/datarouter/... -///score/mw/log/rust/...

Fix review comments for clang-tidy PR adoption address review comments on visibility and clang-tidy scope Fix review comments on grpc-java and clang-tidy scope

rmaddikery

Integration tests will be fixed here: #152

RSingh1511 had a problem deploying to workflow-approval March 25, 2026 06:27 — with GitHub Actions Failure

RSingh1511 force-pushed the rs/clang_tidy branch from 11357b9 to f72c14b Compare March 25, 2026 06:29

RSingh1511 had a problem deploying to workflow-approval March 25, 2026 06:29 — with GitHub Actions Failure

RSingh1511 force-pushed the rs/clang_tidy branch from f72c14b to ccc7eab Compare March 25, 2026 06:31

RSingh1511 had a problem deploying to workflow-approval March 25, 2026 06:31 — with GitHub Actions Failure

RSingh1511 requested a review from rmaddikery March 25, 2026 06:31

RSingh1511 force-pushed the rs/clang_tidy branch from ccc7eab to fe19426 Compare March 25, 2026 06:37

RSingh1511 had a problem deploying to workflow-approval March 25, 2026 06:37 — with GitHub Actions Failure

RSingh1511 force-pushed the rs/clang_tidy branch from fe19426 to aaedbdd Compare March 25, 2026 06:52

RSingh1511 had a problem deploying to workflow-approval March 25, 2026 06:52 — with GitHub Actions Failure

RSingh1511 force-pushed the rs/clang_tidy branch from aaedbdd to 37aa6e7 Compare March 25, 2026 07:16

RSingh1511 had a problem deploying to workflow-approval March 25, 2026 07:16 — with GitHub Actions Failure

RSingh1511 force-pushed the rs/clang_tidy branch from 37aa6e7 to 5e0aa14 Compare March 25, 2026 08:32

RSingh1511 had a problem deploying to workflow-approval March 25, 2026 08:32 — with GitHub Actions Failure

RSingh1511 force-pushed the rs/clang_tidy branch from 5e0aa14 to b931d3e Compare March 25, 2026 09:38

RSingh1511 had a problem deploying to workflow-approval March 25, 2026 09:38 — with GitHub Actions Failure

RSingh1511 requested a review from mobileinfo April 14, 2026 11:11

RSingh1511 had a problem deploying to workflow-approval May 14, 2026 05:01 — with GitHub Actions Failure

RSingh1511 had a problem deploying to workflow-approval May 14, 2026 05:02 — with GitHub Actions Failure

RSingh1511 force-pushed the rs/clang_tidy branch from 95238b1 to d75c12c Compare May 14, 2026 05:38

RSingh1511 had a problem deploying to workflow-approval May 14, 2026 05:38 — with GitHub Actions Failure

RSingh1511 requested a deployment to workflow-approval June 10, 2026 09:15 — with GitHub Actions Waiting

RSingh1511 force-pushed the rs/clang_tidy branch from 86dc8b2 to 25274ec Compare June 10, 2026 09:26

RSingh1511 requested a deployment to workflow-approval June 10, 2026 09:26 — with GitHub Actions Waiting

RSingh1511 force-pushed the rs/clang_tidy branch from 25274ec to 9e7a0d0 Compare June 10, 2026 14:24

RSingh1511 requested a deployment to workflow-approval June 10, 2026 14:24 — with GitHub Actions Waiting

RSingh1511 force-pushed the rs/clang_tidy branch from 9e7a0d0 to f4bff09 Compare June 10, 2026 14:35

RSingh1511 requested a deployment to workflow-approval June 10, 2026 14:35 — with GitHub Actions Waiting

RSingh1511 force-pushed the rs/clang_tidy branch from f4bff09 to c7b3f11 Compare June 10, 2026 15:37

RSingh1511 requested a deployment to workflow-approval June 10, 2026 15:37 — with GitHub Actions Waiting

rmaddikery reviewed Jun 11, 2026

View reviewed changes

Comment thread .github/workflows/clang_tidy.yml Outdated

rmaddikery reviewed Jun 11, 2026

View reviewed changes

Comment thread MODULE.bazel

rmaddikery reviewed Jun 11, 2026

View reviewed changes

mobileinfo approved these changes Jun 11, 2026

View reviewed changes

rmaddikery reviewed Jun 15, 2026

View reviewed changes

Comment thread score/mw/log/detail/common/BUILD

rmaddikery reviewed Jun 15, 2026

View reviewed changes

Comment thread .bazelrc Outdated

rmaddikery reviewed Jun 16, 2026

View reviewed changes

RSingh1511 mentioned this pull request Jun 17, 2026

make_clang_tidy_aspect should skip source files from external Bzlmod repositories (similar to angle_includes_are_system for headers) eclipse-score/score_cpp_policies#8

Open

Adopt clang-tidy support from @score_cpp_policies

683a4bc

Fix review comments for clang-tidy PR adoption address review comments on visibility and clang-tidy scope Fix review comments on grpc-java and clang-tidy scope

rmaddikery approved these changes Jun 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adopt clang-tidy support from @score_cpp_policies#77

Adopt clang-tidy support from @score_cpp_policies#77
rmaddikery merged 1 commit into
eclipse-score:mainfrom
RSingh1511:rs/clang_tidy

RSingh1511 commented Mar 25, 2026

Uh oh!

github-actions Bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

Uh oh!

rmaddikery Jun 11, 2026

Uh oh!

RSingh1511 Jun 11, 2026

Uh oh!

rmaddikery Jun 11, 2026

Uh oh!

RSingh1511 Jun 11, 2026

Uh oh!

Uh oh!

rmaddikery Jun 11, 2026 •

edited

Loading

Uh oh!

RSingh1511 Jun 11, 2026

Uh oh!

Uh oh!

Uh oh!

rmaddikery Jun 16, 2026

Uh oh!

RSingh1511 Jun 17, 2026

Uh oh!

rmaddikery left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	# Clang-tidy: bazel test --config=clang-tidy //score/mw/...
	# Clang-tidy: bazel test --config=clang-tidy //score/...

	# TODO(https://github.com/eclipse-score/baselibs/issues/266)
	# Due to incoming transitive deps from baselibs flatbuffers module.
	# FIXME: To be removed after https://github.com/eclipse-score/baselibs/issues/266 is resolved

Conversation

RSingh1511 commented Mar 25, 2026

Notes for Reviewer

Pre-Review Checklist for the PR Author

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

References

Uh oh!

github-actions Bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

Uh oh!

rmaddikery Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

RSingh1511 Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

rmaddikery Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

RSingh1511 Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rmaddikery Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RSingh1511 Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rmaddikery Jun 16, 2026

Choose a reason for hiding this comment

Include only cpp for now

Uh oh!

RSingh1511 Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

rmaddikery left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Mar 25, 2026 •

edited

Loading

rmaddikery Jun 11, 2026 •

edited

Loading