Add ARM64 Linux layout support to score_log_bridge#149
Draft
Subramanian-K812 wants to merge 1 commit into
Draft
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
arm64-linuxplatform support toscore/mw/log/rust/score_log_bridge/BUILDso that the C++/Rust log bridge builds correctly on
aarch64-linuxtargets(e.g.
eb-aarch64/ ebclfsa SDK).Why
The
adaptercc_library andscore_log_bridgerust_library both use aselect()to emit the correct layout-compatibility define (
x86_64_linux,arm64_qnx, etc.).Without an
arm64-linuxentry, builds targetingaarch64-linuxfall through to//conditions:default: [], meaning no define is set. This causes a compilationfailure in the C++/Rust FFI interface because the struct layout is undefined.
Change
config_setting(name = "arm64-linux", ...)forarm64 + linux.":arm64-linux": ["arm64_linux"]to thedefinesselect incc_libraryand the
crate_featuresselect in bothrust_libraryandrust_test.