Skip to content

Launch Manager loads the new configuration file#248

Open
paulquiring wants to merge 6 commits into
eclipse-score:mainfrom
etas-contrib:feature/lm-use-new-configuration
Open

Launch Manager loads the new configuration file#248
paulquiring wants to merge 6 commits into
eclipse-score:mainfrom
etas-contrib:feature/lm-use-new-configuration

Conversation

@paulquiring

@paulquiring paulquiring commented Jun 15, 2026

Copy link
Copy Markdown
Contributor
  • Map user-facing json config to the new flatbuffer config
  • Load new launch manager config
  • Introduce adapters to make the rest of the code work with the new configuration content
  • Remove the legacy configuration files

Closes: #209

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: a984e836-7a99-48ab-b9d4-a8786dbdcd7a
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (26 packages loaded, 10 targets configured)

Analyzing: target //:license-check (79 packages loaded, 10 targets configured)

Analyzing: target //:license-check (137 packages loaded, 1017 targets configured)

Analyzing: target //:license-check (145 packages loaded, 5383 targets configured)

Analyzing: target //:license-check (155 packages loaded, 5453 targets configured)

Analyzing: target //:license-check (157 packages loaded, 5746 targets configured)

Analyzing: target //:license-check (161 packages loaded, 10134 targets configured)

Analyzing: target //:license-check (162 packages loaded, 10142 targets configured)

INFO: Analyzed target //:license-check (163 packages loaded, 10268 targets configured).
[12 / 16] [Prepa] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes ... (2 actions, 0 running)
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 22.967s, Critical Path: 2.48s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

Comment thread scripts/config_mapping/lifecycle_config.py
@paulquiring paulquiring marked this pull request as ready for review June 16, 2026 08:02
}

bool ConfigCfgFactory::createAliveSupervisions(std::vector<supervision::Alive>& f_alive_r,
std::vector<ifappl::Checkpoint>& f_checkpoints_r,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Unit Tests for the new file

Comment thread score/launch_manager/daemon/src/configuration/configuration_adapter.cpp Outdated
Comment thread score/launch_manager/daemon/src/configuration/configuration_adapter.hpp Outdated
Comment thread score/launch_manager/daemon/src/main.cpp Outdated
@S-MOHAMD

Copy link
Copy Markdown
Contributor

Please lnk corresponding issue/bug.
see: https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue

@paulquiring paulquiring force-pushed the feature/lm-use-new-configuration branch from f13cffe to eb807a1 Compare June 18, 2026 08:28
@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@NicolasFussberger NicolasFussberger moved this from Backlog to In Progress in LCM - Lifecycle & Health FT Jun 18, 2026
@paulquiring paulquiring force-pushed the feature/lm-use-new-configuration branch from cd95b35 to c2e120c Compare June 18, 2026 11:42
Comment thread scripts/config_mapping/config.bzl Outdated
Comment thread score/launch_manager/daemon/src/main.cpp Outdated
Comment thread score/launch_manager/daemon/src/main.cpp Outdated
Comment thread score/launch_manager/daemon/src/main.cpp
Comment thread score/launch_manager/daemon/src/configuration/configuration_adapter.cpp Outdated
Comment thread score/launch_manager/daemon/src/configuration/configuration_adapter.cpp Outdated
Comment thread score/launch_manager/daemon/src/alive_monitor/details/factory/FlatCfgFactory.cpp Outdated
Comment thread score/launch_manager/daemon/src/alive_monitor/details/factory/FlatCfgFactory.cpp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate Launch Manager from the reading the old configuration file format to the new format

4 participants