mw/com: Add integration tests for moving SkeletonEvent#559
Open
bemerybmw wants to merge 1 commit into
Open
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
bemerybmw
force-pushed
the
brem_skeleton_event_move_tests
branch
2 times, most recently
from
ef9c161 to
cc91370
Compare
In the near future, we should implement similar tests for SkeletonFields and SkeletonMethods. We should also implement similar tests on proxy side.
bemerybmw
force-pushed
the
brem_skeleton_event_move_tests
branch
from
cc91370 to
10cbaef
Compare
bemerybmw
commented
Jun 18, 2026
| hdrs = ["proxy_container.h"], | ||
| features = COMPILER_WARNING_FEATURES, | ||
| visibility = [ | ||
| "//score/mw/com/test/methods:__subpackages__", |
Contributor
Author
There was a problem hiding this comment.
These changes are temporary, Sahithi has a pr moving them into shared resources
bemerybmw
requested review from
LittleHuba,
castler,
crimson11,
hoe-jo and
limdor
as code owners
bemerybmw
commented
Jun 19, 2026
| std::cerr << "Unable to set signal handler for SIGINT and/or SIGTERM, cautiously continuing" << std::endl; | ||
| } | ||
|
|
||
| const auto num_send_iterations = [&test_configuration]() { |
Contributor
Author
There was a problem hiding this comment.
Extract this since it's duplicated in all 3 mains
bemerybmw
commented
Jun 19, 2026
| # ******************************************************************************* | ||
| from test_fixture import consumer, provider, SkeletonMoveScenario | ||
|
|
||
| NUMBER_OF_SAMPLES_TO_SEND_PER_OFFER = 10 |
Contributor
Author
There was a problem hiding this comment.
This value is not really important for the test and so could be a constant defined in c++ rather than making it configurable here.
castler
added
the
test-qnx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the near future, we should implement similar tests for SkeletonFields and SkeletonMethods. We should also implement similar tests on proxy side.