Implement integration tests for fields with set and notifier#463
Draft
sahithi-nukala wants to merge 13 commits into
Draft
Implement integration tests for fields with set and notifier#463sahithi-nukala wants to merge 13 commits into
sahithi-nukala wants to merge 13 commits into
Conversation
sahithi-nukala
force-pushed
the
sah_add_integration_test_for_fields
branch
4 times, most recently
from
8306eb3 to
38982b6
Compare
bemerybmw
requested changes
May 22, 2026
sahithi-nukala
force-pushed
the
sah_add_integration_test_for_fields
branch
6 times, most recently
from
7bd4c90 to
a4435a5
Compare
sahithi-nukala
requested review from
LittleHuba,
castler,
crimson11,
hoe-jo and
limdor
as code owners
bemerybmw
reviewed
May 27, 2026
sahithi-nukala
force-pushed
the
sah_add_integration_test_for_fields
branch
8 times, most recently
from
0e981e5 to
5496cf0
Compare
sahithi-nukala
force-pushed
the
sah_add_integration_test_for_fields
branch
from
5496cf0 to
4039570
Compare
sahithi-nukala
force-pushed
the
sah_add_integration_test_for_fields
branch
7 times, most recently
from
bd0c790 to
ac8a5e4
Compare
sahithi-nukala
force-pushed
the
sah_add_integration_test_for_fields
branch
from
ac8a5e4 to
ea394c4
Compare
sahithi-nukala
force-pushed
the
sah_add_integration_test_for_fields
branch
2 times, most recently
from
2b5d4e4 to
e15e762
Compare
ProcessSynchronizer was located in methods_test_resources but was already used by field tests. Move it to common_test_resources and update all include paths and BUILD dependencies accordingly.
- Update test_constants: replace kSetValidValue/kSetAcceptedValue with kSetTransformedValue and add kUpdatedValue - Update BUILD files to reference the new common interface targets - Update field_provider to use updated constants and logic - Update integration test fixture to accept config filename parameter so notifier and set_and_notifier tests use separate manifests - Rename test_field_set_value -> test_field_set_and_notifier_value
Register the receive handler for kUpdatedValue before notifying the provider to ensure the LoLa notification is never missed. LoLa notifications are fire-and-forget. If the provider called Update(kUpdatedValue) before the consumer registered its receive handler, the OS notification fired to zero handlers and was lost, causing WaitForValue to time out after 1000ms.
sahithi-nukala
force-pushed
the
sah_add_integration_test_for_fields
branch
from
e15e762 to
2f981d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.