Remove timestamps from generated outputs#309
Open
arthurvl wants to merge 1 commit into
Open
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
arthurvl
force-pushed
the
remove-timestamps
branch
from
0704bbb to
bf4c9cc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
For creating reproducible builds, we should not add timestamps in comments in generated outputs.
arthurvl
force-pushed
the
remove-timestamps
branch
from
bf4c9cc to
bbf5ad5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
pzygielo
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For creating reproducible builds, we should not add timestamps in comments in generated outputs. This pull request removes the output of the generated timestamps, but keeps the generation otherwise identical, to the point of the golden master verification in the testsuite still matching the newly generated outputs.
Provides one possible solution to Issue #308