Updated unit tests

Author: jcwalker

DSCResources/DSR_ReplaceText/DSR_ReplaceText.psm1

@@ -161,7 +161,7 @@ function Set-TargetResource
     elseif ( [regex]::Matches($fileContent, $Search).Count -eq 0 )
     {
         # configuration file exists but Text does not exist so lets add it
-        $fileContent = "{0}`n`r{1}" -f $fileContent, $Text
+        $fileContent = Add-ConfigurationEntry -FileContent $fileContent -Text $Text
     }
     else
     {
@@ -172,9 +172,8 @@ function Set-TargetResource
     Set-Content `
         -Path $Path `
         -Value $fileContent `
+        -NoNewline `
         -Force
-        #-NoNewline `
-
 }
 
 <#
@@ -346,4 +345,41 @@ function Assert-ParametersValid
     } # if
 }
 
+<#
+    .SYNOPSIS
+        Uses the stringBuilder class to append a configuration entry to the existing file content.
+
+    .PARAMETER FileContent
+        The existing file content of the configuration file.
+
+    .PARAMETER Text
+        The text to replace the text identifed by the RegEx.
+#>
+function Add-ConfigurationEntry
+{
+    param
+    (
+        [Parameter()]
+        [string]
+        $FileContent,
+
+        [Parameter()]
+        [string]
+        $Text
+    )
+
+    $stringBuilder = New-Object System.Text.StringBuilder
+
+    $fileContentArray = $FileContent.Trim() -split '\n'
+
+    foreach ($line in $fileContentArray)
+    {
+        $null = $stringBuilder.AppendLine($line.Trim())
+    }
+
+    $null = $stringBuilder.AppendLine($Text)
+
+    return $stringBuilder.ToString()
+}
+
 Export-ModuleMember -Function *-TargetResource

Tests/Unit/DSR_ReplaceText.Tests.ps1

@@ -36,6 +36,7 @@ try
         $script:testSecret = 'TestSecret'
         $script:testSearch = "Setting\.Two='(.)*'"
         $script:testSearchNoFind = "Setting.NotExist='(.)*'"
+        $script:testTextReplaceNoFind = "Setting.NotExist='$($script:testText)'"
         $script:testTextReplace = "Setting.Two='$($script:testText)'"
         $script:testSecretReplace = "Setting.Two='$($script:testSecret)'"
         $script:testSecureSecretReplace = ConvertTo-SecureString -String $script:testSecretReplace -AsPlainText -Force
@@ -57,6 +58,16 @@ Setting.Two='$($script:testText)'
 Setting.Two='$($script:testText)'
 Setting3.Test=Value4
 
+"@
+
+$script:testFileExpectedTextContentNewKey = @"
+Setting1=Value1
+Setting.Two='Value2'
+Setting.Two='Value3'
+Setting.Two='$($script:testText)'
+Setting3.Test=Value4
+Setting.NotExist='$($script:testText)'
+
 "@
 
         $script:testFileExpectedSecretContent = @"
@@ -206,6 +217,55 @@ Setting3.Test=Value4
                 }
             }
 
+            Context 'File exists and search text can not be found'{
+                # verifiable (should be called) mocks
+                Mock `
+                    -CommandName Assert-ParametersValid `
+                    -ModuleName 'DSR_ReplaceText' `
+                    -Verifiable
+
+                Mock `
+                    -CommandName Get-Content `
+                    -ParameterFilter { $path -eq $script:testTextFile } `
+                    -MockWith { $script:testFileContent } `
+                    -Verifiable
+
+                Mock `
+                    -CommandName Set-Content `
+                    -ParameterFilter {
+                        ($path -eq $script:testTextFile) -and `
+                        ($value -eq $script:testFileExpectedTextContentNewKey)
+                    } `
+                    -Verifiable
+
+                It 'Should not throw an exception' {
+                    { $script:result = Set-TargetResource `
+                        -Path $script:testTextFile `
+                        -Search $script:testSearchNoFind `
+                        -Text $script:testTextReplaceNoFind `
+                        -Verbose
+                    } | Should -Not -Throw
+                }
+
+                It 'Should call the expected mocks' {
+                    Assert-VerifiableMock
+                    Assert-MockCalled -CommandName Assert-ParametersValid -Exactly 1
+
+                    Assert-MockCalled `
+                        -CommandName Get-Content `
+                        -ParameterFilter { $path -eq $script:testTextFile } `
+                        -Exactly 1
+
+                    Assert-MockCalled `
+                        -CommandName Set-Content `
+                        -ParameterFilter {
+                            ($path -eq $script:testTextFile) -and `
+                            ($value -eq $script:testFileExpectedTextContentNewKey)
+                        } `
+                        -Exactly 1
+                }
+            }
+
             Context 'File exists and search secret can be found' {
                 # verifiable (should be called) mocks
                 Mock `

Tests/Unit/TestFile.txt

@@ -0,0 +1,6 @@
+Setting1=Value1
+Setting.Two='Value2'
+Setting.Two='Value3'
+Setting.Two='TestText'
+Setting3.Test=Value4Setting.NotExist='TestText'
+