Refactored ReplaceText.psm1 to return false is search text isn't found

Author: jcwalker

DSCResources/DSR_ReplaceText/DSR_ReplaceText.psm1

@@ -155,18 +155,26 @@ function Set-TargetResource
 
     if ($null -eq $fileContent)
     {
+        # configuration file does not exist
         $fileContent = $Text
     }
+    elseif ( [regex]::Matches($fileContent, $Search).Count -eq 0 )
+    {
+        # configuration file exists but Text does not exist so lets add it
+        $fileContent = "{0}`n`r{1}" -f $fileContent, $Text
+    }
     else
     {
+        # configuration file exists but Text not in a desired state so lets update it
         $fileContent = $fileContent -Replace $Search, $Text
     }
 
     Set-Content `
         -Path $Path `
         -Value $fileContent `
-        -NoNewline `
         -Force
+        #-NoNewline `
+
 }
 
 <#
@@ -243,7 +251,7 @@ function Test-TargetResource
         Write-Verbose -Message ($localizedData.StringNotFoundMessage -f `
                 $Path, $Search)
 
-        return $true
+        return $false
     }
 
     # Flag to signal whether settings are correct

DSCResources/DSR_ReplaceText/en-US/DSR_ReplaceText.strings.psd1

@@ -2,7 +2,7 @@
 
 ConvertFrom-StringData @'
     SearchForTextMessage = Searching using RegEx '{1}' in file '{0}'.
-    StringNotFoundMessage = String not found using RegEx '{1}' in file '{0}', change not required.
+    StringNotFoundMessage = String not found using RegEx '{1}' in file '{0}', change required.
     StringMatchFoundMessage = String(s) '{2}' found using RegEx '{1}' in file '{0}'.
     StringReplacementRequiredMessage = String found using RegEx '{1}' in file '{0}', replacement required.
     StringNoReplacementMessage = String found using RegEx '{1}' in file '{0}', no replacement required.

Tests/Unit/DSR_ReplaceText.Tests.ps1

@@ -341,7 +341,7 @@ Setting3.Test=Value4
                 }
 
                 It 'Should return true' {
-                    $script:result | Should -Be $true
+                    $script:result | Should -Be $false
                 }
 
                 It 'Should call the expected mocks' {
@@ -537,6 +537,10 @@ Setting3.Test=Value4
                 }
             }
 
+            Context 'File exists and search text cannot be found' {
+
+            }
+
             Context 'File does not exist' {
                 # verifiable (should be called) mocks
                 Mock `