feat: add replication info to /metrics endpoint#7069
feat: add replication info to /metrics endpoint#7069romange merged 1 commit intodragonflydb:mainfrom
/metrics endpoint#7069Conversation
🤖 Augment PR SummarySummary: This PR exposes replica-side replication state in the Prometheus Changes:
Technical Notes: The implementation reuses the existing replication summary fields already used by the INFO replication output, keeping metrics consistent with runtime replication state. 🤖 Was this summary useful? React with 👍 or 👎 |
|
@EricHayter thanks for working on it. |
c532fba to
c2295e1
Compare
|
Please sign your commits @EricHayter |
I believe my commits already include a sign-off, but the PR description does not. Should I also add the sign-off to the PR message? |
c2295e1 to
faaef88
Compare
faaef88 to
ded39ce
Compare
|
I meant with sign with gpg key, see #7122 for details. |
Exposes 4 new fields to the `/metrics` endpoint relating to replication info: - `master_link_status` - `master_last_io_seconds_ago` - `master_sync_in_progress` - `slave_repl_offset` This commit also adds integration testing to validate the new functionality. Fixes dragonflydb#6183 Signed-off-by: Eric <hayter.eric@gmail.com>
ded39ce to
9c950a5
Compare
|
Sorry for the delay on getting this signed. I initially amended the commit locally, but didn’t realize I also needed to add my public key to GitHub for the signature to be recognized. It should be properly signed now. |
|
Thank you, Eric! |
Exposes 4 new fields to the
/metricsendpoint relating to replication info:master_link_statusmaster_last_io_seconds_agomaster_sync_in_progressslave_repl_offsetThis commit also adds integration testing to validate the new functionality.
Fixes #6183