Enable nullable reference types in MamJsonToXml.cs#11453
Merged
Conversation
7 tasks
Agent-Logs-Url: https://github.com/dotnet/android/sessions/7b0e9747-724f-4f9e-b66c-1c20ed3b9d4a Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix nullable reference types in MamJsonToXml.cs
Enable nullable reference types in May 22, 2026
MamJsonToXml.cs
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to enable nullable reference types (NRT) for the MamJsonToXml MSBuild task and remove the existing null! usage on a [Required] task property to align with the repo’s NRT conventions.
Changes:
- Adds
#nullable enableat the top ofMamJsonToXml.cs. - (Intended per PR description, but not present in the current diff) Replace
null!on the[Required]XmlMappingOutputproperty with a non-null default instance.
| @@ -1,3 +1,4 @@ | |||
| #nullable enable | |||
jonathanpeppers
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MamJsonToXml.csusesnull!on a[Required] ITaskItemproperty, violating repo NRT conventions.#nullable enableas the first linenull!withnew TaskItem ()onXmlMappingOutput, matching the established pattern for[Required]properties (= ""for strings,= []for arrays,= new TaskItem ()for task items)