Restore synchronous PermittedTriggers for sync-only state machines#647
Open
mclift wants to merge 1 commit into
Open
Restore synchronous PermittedTriggers for sync-only state machines#647mclift wants to merge 1 commit into
mclift wants to merge 1 commit into
Conversation
…nc-only state machines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR revisits the deprecation of synchronous
PermittedTriggers/GetPermittedTriggersdiscussed in #634. After concerns were raised about marking these members for deprecation, the goal is to keep synchronous introspection available for fully synchronous workflows, while making the async boundary explicit when async guard evaluation is actually required.Note that this change introduces a new exception condition:
InvalidOperationExceptionis thrown whenPermittedTriggers/GetPermittedTriggersis used on a state that hasasynctriggers.PermittedTriggersandGetPermittedTriggersGetPermittedTriggersAsyncInvalidOperationExceptionwhen async guards are present in the current state or one of its superstatesGetPermittedTriggersAsyncas the full-fidelity API for all configurationsToString()to use the synchronous path when async guard evaluation is not needed and fall back to async permitted-trigger enumeration only when required