Added bind for local TCP#4
Conversation
|
Thanks for this! I need to double check it before merging, but I'll leave a quick comment |
| } | ||
| } | ||
|
|
||
| if(source != NULL ){ |
There was a problem hiding this comment.
please match style to the rest of the code
| size_t mcmc_min_buffer_size(int options); | ||
| int mcmc_parse_buf(const char *buf, size_t read, mcmc_resp_t *r); | ||
| int mcmc_connect(void *c, char *host, char *port, int options); | ||
| int mcmc_connect(void *c, char *source, char *host, char *port, int options); |
There was a problem hiding this comment.
This might be okay since I've no public ABI on this library yet, but normally the process is like:
mcmc_connect_with_source(new function params) (idk about the name exactly, but something like this)
#define mcmc_connect(old params) mcmc_connect_with_source(new params, NULL source)
reduces downstream burden.
There was a problem hiding this comment.
I've put it as mcmc_connect_ex (extended) , I thought it would better suit the function in the future.
Just let me know if you want it as mcmc_connect_source then I'll put up a commit for that.
2 participants
This is addressing issue #1271 in memcached.
The memcached library will also need changes where mcmc_connect is used to match the updated parameter list.
I thought it would better to post a PR here first and discuss before I move on to try and integrate into memcached code.