fix: handle missing type in schema and orphaned function calls in Responses API#2362
Merged
dgageot merged 1 commit intodocker:mainfrom Apr 10, 2026
Merged
Conversation
…ponses API - Add ensureTypeFields() to schema normalization pipeline to inject missing 'type' keys required by the OpenAI Responses API (fixes notion-search tool's additionalProperties rejection) - Add error results for remaining tool calls when a batch is cancelled mid-way, preventing orphaned function_call items in conversation history - Add defensive safety net in convertMessagesToResponseInput to inject placeholder outputs for any orphaned function calls Closes docker#2354 Assisted-By: docker-agent
trungutt
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two Responses API errors reported in #2354:
Schema validation error (
additionalPropertiesmissingtype): AddedensureTypeFields()to the schema normalization pipeline to inject missingtypekeys. The OpenAI Responses API requires all schema nodes to have an explicit type."No tool output found for function call": When a tool call was cancelled mid-batch, remaining unprocessed tool calls had no results added to the conversation history, causing orphaned
function_callitems. Fixed by adding error results for remaining calls on cancellation, plus a defensive safety net inconvertMessagesToResponseInputthat injects placeholder outputs for any orphaned function calls.Closes #2354