story/HOP-63#49
Open
Girik1105 wants to merge 2 commits into
Open
Conversation
…dge cases, incorported metadata field in resources abstract model and added it in website and pdf resources
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
We need to add more metadata fields to Resources
Description
those should be part of the Resource class so they are applicable to all.
There will be more, but we’ll start with:
Date Published - this should probably be an ISO date as it can be anything from year, to month year, to day month year. Or unknown, in which case we’ll just set it to null.
The following three fields will be a controlled list, but the available options would come from the csv import. So I think we want to have another module for each of these and then create objects as rows are imported.
Document Type
Document Author Institution
Institution Type
We’ll have some more metadata fields but I’m waiting to hear back on what exactly those are and how they look like.
We also want to add the metadata to the MCP server but here I think we want to add them as json to make the MCP agnostic to the types of documents stored.
HOP-63
Anything else the reviewer needs to know?
Does this Pull request depend on any other?